PurchaseTester: fixed watchOS build and ASC deployment
#2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
changed the title
PurchaseTester: fixed watchOS buildPurchaseTester: fixed watchOS build and ASC deployment
Fixes https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/12159/workflows/89db4b5d-bafc-4b99-ac86-4f205e49f1bf/jobs/81368 We were not correctly embedding (and therefore building) the `watchOS` extension until #2685. That exposed a bunch of other issues which this fixes.
NachoSoto
force-pushed
the
purchase-tester-watchos
branch
from
cdc3c8a
to
d1949e0
Compare
Codecov Report
@@ Coverage Diff @@
## main #2701 +/- ##
==========================================
- Coverage 86.58% 86.57% -0.01%
==========================================
Files 211 211
Lines 14987 14987
==========================================
- Hits 12976 12975 -1
- Misses 2011 2012 +1 |
NachoSoto
commented
Jun 23, 2023
| @@ -790,13 +792,13 @@ | |||
| "PROVISIONING_PROFILE_SPECIFIER[sdk=iphoneos*]" = "match AppStore com.revenuecat.sampleapp"; | |||
| "PROVISIONING_PROFILE_SPECIFIER[sdk=macosx*]" = "match AppStore com.revenuecat.sampleapp macos"; | |||
| "PROVISIONING_PROFILE_SPECIFIER[sdk=watchos*]" = "match AppStore com.revenuecat.sampleapp"; | |||
| SUPPORTED_PLATFORMS = "appletvos appletvsimulator iphoneos iphonesimulator macosx watchos watchsimulator xros xrsimulator"; | |||
There was a problem hiding this comment.
The main target was configured as compatible with watchOS, which didn't make sense.
NachoSoto
commented
Jun 23, 2023
Comment on lines
-31
to
-40
| <TestableReference | ||
| skipped = "NO"> | ||
| <BuildableReference | ||
| BuildableIdentifier = "primary" | ||
| BlueprintIdentifier = "2CD2C501278C9B02005D1CC2" | ||
| BuildableName = "Tests iOS.xctest" | ||
| BlueprintName = "Tests iOS" | ||
| ReferencedContainer = "container:PurchaseTester.xcodeproj"> | ||
| </BuildableReference> | ||
| </TestableReference> |
There was a problem hiding this comment.
There is no test target, so this was a dead link.
tonidero
approved these changes
Jun 26, 2023
tonidero
pushed a commit
that referenced
this pull request
Jun 26, 2023
**This is an automatic release.** ### Bugfixes * Fix google play purchases missing purchase date (#2703) via Toni Rico (@tonidero) ### Other Changes * `PurchaseTester`: fixed `watchOS` build and ASC deployment (#2701) via NachoSoto (@NachoSoto) * Add `Data.sha1` (#2696) via NachoSoto (@NachoSoto) * Refactor: extract `ErrorResponse` into its own file (#2697) via NachoSoto (@NachoSoto) * Add `Sequence<AdditiveArithmetic>.sum()` (#2694) via NachoSoto (@NachoSoto) * Refactored `Data.asString` implementation (#2695) via NachoSoto (@NachoSoto) * `Diagnostics`: new `FileHandler` for abstracting file operations (#2673) via NachoSoto (@NachoSoto)
tonidero
added a commit
that referenced
this pull request
Jun 26, 2023
### Description While uploading purchase tester to testflight, we were getting these errors: ``` [Application Loader Error Output]: ERROR: [ContentDelivery.Uploader] Asset validation failed (90396) Invalid Icon. The watch application 'PurchaseTester.app/Watch/PurchaseTesterWatchOS.app' contains an icon file 'Icon [email protected]' with an alpha channel. Icons should not have an alpha channel. [Application Loader Error Output]: ERROR: [ContentDelivery.Uploader] Asset validation failed (90717) Invalid App Store Icon. The App Store Icon in the asset catalog in 'PurchaseTester.app/Watch/PurchaseTesterWatchOS.app' can't be transparent nor contain an alpha channel. ``` This icon was added in #2701. After trying it manually, removing the alpha channel seems to have worked in fixing the issue while uploading. This PR just changes that icon with a version without an alpha channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/12159/workflows/89db4b5d-bafc-4b99-ac86-4f205e49f1bf/jobs/81368
We were not correctly embedding (and therefore building) the
watchOSextension until #2685. That exposed a bunch of other issues which this fixes.