Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestStoreProduct: made available on release builds #2861

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

NachoSoto
Copy link
Contributor

See #2711. This is needed for #2855. In order to be able to create test products for the paywall loading screen, we need to be able to do this in release builds as well.

Another benefit of exposing TestStoreProduct in release builds is that it's also usable for pre-built versions of the SDK (like Carthage).

See #2711. This is needed for #2855. In order to be able to create test products for the paywall loading screen, we need to be able to do this in release builds as well.
Another benefit of exposing `TestStoreProduct` in release builds is that it's also usable for pre-built versions of the SDK (like Carthage).
@NachoSoto NachoSoto requested a review from a team July 23, 2023 15:40
@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Merging #2861 (38e88c5) into main (b4a71a9) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2861      +/-   ##
==========================================
- Coverage   86.55%   86.51%   -0.05%     
==========================================
  Files         217      217              
  Lines       15513    15509       -4     
==========================================
- Hits        13428    13417      -11     
- Misses       2085     2092       +7     
Impacted Files Coverage Δ
...Purchasing/StoreKitAbstractions/StoreProduct.swift 73.97% <ø> (-1.36%) ⬇️
...reKitAbstractions/Test Data/TestStoreProduct.swift 100.00% <ø> (ø)
...tractions/Test Data/TestStoreProductDiscount.swift 0.00% <ø> (ø)

... and 4 files with indirect coverage changes

@NachoSoto NachoSoto merged commit 6776347 into main Jul 24, 2023
2 checks passed
@NachoSoto NachoSoto deleted the test-product-release branch July 24, 2023 22:07
NachoSoto added a commit that referenced this pull request Jul 26, 2023
**This is an automatic release.**

_This release is compatible with Xcode 15 beta 5 and visionOS beta 2_

### Bugfixes
* `xrOS`: fixed `SubscriptionStoreView` for visionOS beta 2 (#2884) via
Josh Holtz (@joshdholtz)
### Performance Improvements
* `Perf`: update `CustomerInfo` cache before anything else (#2865) via
NachoSoto (@NachoSoto)
### Other Changes
* `SimpleApp`: added support for localization (#2880) via NachoSoto
(@NachoSoto)
* `TestStoreProduct`: made available on release builds (#2861) via
NachoSoto (@NachoSoto)
* `Tests`: increased default logger capacity (#2870) via NachoSoto
(@NachoSoto)
* `CustomEntitlementComputation`: removed `invalidateCustomerInfoCache`
(#2866) via NachoSoto (@NachoSoto)
* `SimpleApp`: updates for TestFlight compatibility (#2862) via
NachoSoto (@NachoSoto)
* `BasePurchasesTests`: consolidate to only initialize one `DeviceCache`
(#2863) via NachoSoto (@NachoSoto)
* `Codable`: debug log entire JSON when decoding fails (#2864) via
NachoSoto (@NachoSoto)
* `IntegrationTests`: replaced `Purchases.shared` with a `throw`ing
property (#2867) via NachoSoto (@NachoSoto)
* `NetworkError`: 2 new tests to ensure underlying error is included in
description (#2843) via NachoSoto (@NachoSoto)
* Add SPM `Package.resolved` for Xcode Cloud (#2844) via NachoSoto
(@NachoSoto)
* `CustomEntitlementComputation`: added integration test for
cancellations (#2849) via NachoSoto (@NachoSoto)
* `CustomEntitlementComputation`: removed
`syncPurchases`/`restorePurchases` (#2854) via NachoSoto (@NachoSoto)

---------

Co-authored-by: NachoSoto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants