Paywalls: implemented PostPaywallEventsOperation
#3158
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| // | ||
| // Copyright RevenueCat Inc. All Rights Reserved. | ||
| // | ||
| // Licensed under the MIT License (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // https://opensource.org/licenses/MIT | ||
| // | ||
| // PaywallEventsRequest.swift | ||
| // | ||
| // Created by Nacho Soto on 9/6/23. | ||
|
|
||
| import Foundation | ||
|
|
||
| /// The content of a request to the events endpoints. | ||
| struct PaywallEventsRequest { | ||
|
|
||
| var events: [Event] | ||
|
|
||
| init(events: [Event]) { | ||
| self.events = events | ||
| } | ||
|
|
||
| @available(iOS 15.0, macOS 12.0, tvOS 15.0, watchOS 8.0, *) | ||
| init(events: [PaywallStoredEvent]) { | ||
| self.init(events: events.map { .init(storedEvent: $0) }) | ||
| } | ||
|
|
||
| } | ||
|
|
||
| extension PaywallEventsRequest { | ||
|
|
||
| enum EventType: String { | ||
|
|
||
| case view | ||
| case cancel | ||
| case close | ||
|
|
||
| } | ||
|
|
||
| struct Event { | ||
|
|
||
| let version: Int | ||
| var type: EventType | ||
| var appUserID: String | ||
| var sessionID: String | ||
| var offeringID: String | ||
| var paywallRevision: Int | ||
| var timestamp: Date | ||
| var displayMode: PaywallViewMode | ||
| var darkMode: Bool | ||
| var localeIdentifier: String | ||
|
|
||
| } | ||
|
|
||
| } | ||
|
|
||
| extension PaywallEventsRequest.Event { | ||
|
|
||
| @available(iOS 15.0, macOS 12.0, tvOS 15.0, watchOS 8.0, *) | ||
| init(storedEvent: PaywallStoredEvent) { | ||
| let data = storedEvent.event.data | ||
|
|
||
| self.init( | ||
| version: Self.version, | ||
| type: storedEvent.event.eventType, | ||
| appUserID: storedEvent.userID, | ||
| sessionID: data.sessionIdentifier.uuidString, | ||
| offeringID: data.offeringIdentifier, | ||
| paywallRevision: data.paywallRevision, | ||
| timestamp: data.date, | ||
| displayMode: data.displayMode, | ||
| darkMode: data.darkMode, | ||
| localeIdentifier: data.localeIdentifier | ||
| ) | ||
| } | ||
|
|
||
| private static let version: Int = 1 | ||
|
|
||
| } | ||
|
|
||
| @available(iOS 15.0, macOS 12.0, tvOS 15.0, watchOS 8.0, *) | ||
| private extension PaywallEvent { | ||
|
|
||
| var eventType: PaywallEventsRequest.EventType { | ||
| switch self { | ||
| case .view: return .view | ||
| case .cancel: return .cancel | ||
| case .close: return .close | ||
| } | ||
|
|
||
| } | ||
|
|
||
| } | ||
|
|
||
| // MARK: - Codable | ||
|
|
||
| extension PaywallEventsRequest.EventType: Encodable {} | ||
|
|
||
| extension PaywallEventsRequest.Event: Encodable { | ||
|
|
||
| private enum CodingKeys: String, CodingKey { | ||
|
|
||
| case version | ||
| case type | ||
| case appUserID = "appUserId" | ||
| case sessionID = "sessionId" | ||
| case offeringID = "offeringId" | ||
| case paywallRevision | ||
| case timestamp | ||
| case displayMode | ||
| case darkMode | ||
| case localeIdentifier | ||
|
|
||
| } | ||
|
|
||
| } | ||
|
|
||
| extension PaywallEventsRequest: HTTPRequestBody {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| // | ||
| // Copyright RevenueCat Inc. All Rights Reserved. | ||
| // | ||
| // Licensed under the MIT License (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // https://opensource.org/licenses/MIT | ||
| // | ||
| // PaywallHTTPRequestPath.swift | ||
| // | ||
| // Created by Nacho Soto on 9/5/23. | ||
|
|
||
| import Foundation | ||
|
|
||
| extension HTTPRequest.PaywallPath: HTTPRequestPath { | ||
|
There was a problem hiding this comment. This is thanks to the refactor in #2986 |
||
|
|
||
| static let serverHostURL = URL(string: "https://api-paywalls.revenuecat.com")! | ||
|
|
||
| var authenticated: Bool { | ||
| switch self { | ||
| case .postEvents: | ||
| return true | ||
| } | ||
|
Comment on lines
+21
to
+24
There was a problem hiding this comment. I'm sure this makes sense, but why do all of these do switch self case .postEvents return hardcoded value? why not just return the harcoded value? There was a problem hiding this comment. So that when/if we add a new path the compiler fails and forces us to implement these for the new |
||
| } | ||
|
|
||
| var shouldSendEtag: Bool { | ||
| switch self { | ||
| case .postEvents: | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| var supportsSignatureVerification: Bool { | ||
| switch self { | ||
| case .postEvents: | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| var needsNonceForSigning: Bool { | ||
| switch self { | ||
| case .postEvents: | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| var pathComponent: String { | ||
| switch self { | ||
| case .postEvents: | ||
| return "events" | ||
| } | ||
| } | ||
|
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need main thread for anything in paywall events?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I did that out of habit from other operations, but
ResponseHandlerisn't@MainActoranyway.I'll fix in the next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10da09b