Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copies some CI jobs from GitHub Actions to CircleCI. #101

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

JayShortway
Copy link
Member

Copies some CI jobs from GitHub Actions to CircleCI, so they can be required to run before release. I did not yet remove them from GitHub Actions, because that's still how they're run in PRs. Will do that later.

@JayShortway JayShortway added the ci label Jun 18, 2024
@JayShortway JayShortway requested a review from a team June 18, 2024 12:36
@JayShortway JayShortway self-assigned this Jun 18, 2024
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions but looking good.

.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
Base automatically changed from publish-logic-in-fastlane to main June 20, 2024 10:03
@JayShortway JayShortway merged commit b185e75 into main Jun 20, 2024
5 checks passed
@JayShortway JayShortway deleted the migrate-tests-from-gha-to-cci branch June 20, 2024 10:55
@RCGitBot RCGitBot mentioned this pull request Jun 26, 2024
@RCGitBot RCGitBot mentioned this pull request Sep 4, 2024
@vegaro vegaro added pr:other and removed pr:ci labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants