Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ProductCategory to StoreProduct #114

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

JayShortway
Copy link
Member

It's nullable, because it can be unknown on Android. Deduced this from the Flutter implementation, so let me know if that's incorrect.

@JayShortway JayShortway added the pr:feat A new feature label Jun 26, 2024
@JayShortway JayShortway requested a review from a team June 26, 2024 09:16
@JayShortway JayShortway self-assigned this Jun 26, 2024
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JayShortway JayShortway merged commit 17ee607 into main Jun 26, 2024
5 checks passed
@JayShortway JayShortway deleted the sdk-3489-missing-productcategory-in-storeproduct branch June 26, 2024 14:04
@RCGitBot RCGitBot mentioned this pull request Jun 26, 2024
@RCGitBot RCGitBot mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants