Fix iOS crash showing paywall for current offering #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
approved these changes
Jul 12, 2024
| @@ -1,16 +1,16 @@ | |||
| PODS: | |||
There was a problem hiding this comment.
we may not even wanna commit this file, it'll fall out of date super often
There was a problem hiding this comment.
I see indeed that other hybrids don't have it version controlled either (although PHC does). In general I think it's nice to be a bit more explicit about transitive dependencies, so I'd propose to remove the file once it becomes a problem.
tonidero
approved these changes
Jul 15, 2024
tonidero
reviewed
Jul 15, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says. The commit messages are pretty descriptive. The actual fix is tiny and in the last commit.
Closes #128