Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the API dump #165

Merged

Conversation

JayShortway
Copy link
Member

As the title says. Forgot this in my lil contribution PR 😳

@JayShortway JayShortway added the ci label Aug 28, 2024
@JayShortway JayShortway requested a review from a team August 28, 2024 13:03
@JayShortway JayShortway self-assigned this Aug 28, 2024
@RevenueCat-Danger-Bot
Copy link

1 Warning
⚠️ This PR increases the size of the repo by more than 100.00 KB (increased by 110.18 KB).

Generated by 🚫 Danger

@JayShortway
Copy link
Member Author

Why does Danger say this increases the size of the repo (at all), if we're removing 52 lines? 🤔

@JayShortway JayShortway merged commit e4e360b into integration/sdk-3487-do-not-expose-phc-api Aug 28, 2024
1 check passed
@JayShortway JayShortway deleted the fix-api-dump branch August 28, 2024 14:06
@tonidero
Copy link
Contributor

Why does Danger say this increases the size of the repo (at all), if we're removing 52 lines? 🤔

Hmm that's very weird indeed... Maybe it's comparing it to main? That would make sense...

@JayShortway
Copy link
Member Author

Maybe it's comparing it to main? That would make sense...

Yeah that must be it I think.

@vegaro vegaro added pr:other and removed pr:ci labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants