Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate GitHub Actions to CircleCI #207

Merged
merged 7 commits into from
Sep 20, 2024
Merged

Conversation

JayShortway
Copy link
Member

@JayShortway JayShortway commented Sep 17, 2024

We were still using GitHub Actions for a lot of our CI needs. This PR migrates pretty much everything to CircleCI.

Only 2 things still happen on GitHub Actions after this PR:

  • Submitting our dependency graph to GitHub for vulnerability analysis, visible in the Insights tab above.
  • Deploying the SDK reference site to GitHub Pages.

I figured this was alright, as these 2 things are not part of our core workflows, and they're working well and not in our way. Let me know if you disagree.

This does not do any optimizations. I expect things to be as slow as they were before. That will be a follow-up PR.

Note: once this is approved I will update the branch rules and required checks so this can be merged.

@JayShortway JayShortway self-assigned this Sep 17, 2024
@JayShortway JayShortway requested a review from a team September 20, 2024 10:33
@JayShortway JayShortway marked this pull request as ready for review September 20, 2024 10:33
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@JayShortway JayShortway merged commit b32f55d into main Sep 20, 2024
6 checks passed
@JayShortway JayShortway deleted the migrate-gha-to-circleci branch September 20, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants