Add visionOS support #471
Merged
Add visionOS support #471
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
commented
Jun 28, 2024
| #elif UNITY_IPHONE && !UNITY_EDITOR | ||
| #elif (UNITY_IOS || UNITY_VISIONOS) && !UNITY_EDITOR |
There was a problem hiding this comment.
this would be the reason why before this PR, it would still compile, but no-op
tonidero
approved these changes
Jul 15, 2024
| @@ -1,5 +1,5 @@ | |||
|
|
|||
| #if UNITY_EDITOR && UNITY_IOS | |||
| #if UNITY_EDITOR && (UNITY_IOS || UNITY_VISIONOS) | |||
There was a problem hiding this comment.
I haven't been able to test this, but do we need to also check for vision os in line 16 below? https://docs.unity3d.com/ScriptReference/BuildTarget.VisionOS.html
There was a problem hiding this comment.
Does it support Unity-VisionOS now?
There was a problem hiding this comment.
After testing with the new BuildTarget.VisionOS, this actually brakes with the current unity version we are using and it would be considered a breaking change. In any case, this script shouldn't really be needed in modern unity versions so we can merge without it.
tonidero
force-pushed
the
vision-os-support
branch
from
34bae66
to
74d54b3
Compare
tonidero
pushed a commit
that referenced
this pull request
Oct 2, 2024
**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * Add visionOS support (#471) via Andy Boedo (@aboedo) ### 📦 Dependency Updates * Bump fastlane from 2.222.0 to 2.223.1 (#509) via dependabot[bot] (@dependabot[bot])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding visionOS support