Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix watch util issue 18 and 78 #82

Merged
merged 7 commits into from
Apr 17, 2019
Merged

Conversation

Revolution1
Copy link
Owner

@Revolution1 Revolution1 commented Apr 16, 2019

fix #78
fix #18
fix #61

Repository owner deleted a comment Apr 16, 2019
@Revolution1 Revolution1 force-pushed the fix-watch-util-issue-18-and-78 branch from 056376f to dc8ad3f Compare April 16, 2019 12:46
Repository owner deleted a comment Apr 16, 2019
Repository owner deleted a comment Apr 17, 2019
@Revolution1 Revolution1 force-pushed the fix-watch-util-issue-18-and-78 branch from 17a4370 to c6cff7a Compare April 17, 2019 07:55
Repository owner deleted a comment Apr 17, 2019
@Revolution1 Revolution1 force-pushed the fix-watch-util-issue-18-and-78 branch from c6cff7a to 31e76cb Compare April 17, 2019 08:08
Repository owner deleted a comment Apr 17, 2019
@Revolution1 Revolution1 force-pushed the fix-watch-util-issue-18-and-78 branch from 31e76cb to eb8c8c7 Compare April 17, 2019 08:41
Repository owner deleted a comment Apr 17, 2019
@Revolution1 Revolution1 force-pushed the fix-watch-util-issue-18-and-78 branch from eb8c8c7 to eec80c3 Compare April 17, 2019 08:46
Repository owner deleted a comment Apr 17, 2019
@Revolution1 Revolution1 force-pushed the fix-watch-util-issue-18-and-78 branch from eec80c3 to 8daa908 Compare April 17, 2019 08:51
Repository owner deleted a comment Apr 17, 2019
@Revolution1 Revolution1 force-pushed the fix-watch-util-issue-18-and-78 branch from 8daa908 to 2c5a4a8 Compare April 17, 2019 12:40
@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #82 into master will increase coverage by 0.23%.
The diff coverage is 87.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   91.18%   91.42%   +0.23%     
==========================================
  Files          51       52       +1     
  Lines        2792     2870      +78     
  Branches      286      298      +12     
==========================================
+ Hits         2546     2624      +78     
+ Misses        147      141       -6     
- Partials       99      105       +6
Impacted Files Coverage Δ
etcd3/errors/errors.py 100% <ø> (ø) ⬆️
etcd3/stateful/lock.py 82.81% <100%> (+0.08%) ⬆️
etcd3/client.py 87.38% <100%> (+0.23%) ⬆️
etcd3/errors/__init__.py 100% <100%> (ø) ⬆️
etcd3/utils.py 92% <42.85%> (-8%) ⬇️
tests/conftest.py 50% <50%> (ø)
etcd3/aio_client.py 77.84% <75%> (-0.36%) ⬇️
etcd3/stateful/watch.py 88.23% <86.15%> (+4.43%) ⬆️
tests/test_watch_util.py 95.97% <95.65%> (-0.77%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56adfea...0de182d. Read the comment docs.

Repository owner deleted a comment Apr 17, 2019
@codecov-io
Copy link

codecov-io commented Apr 17, 2019

Codecov Report

Merging #82 into master will increase coverage by 0.29%.
The diff coverage is 88.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   91.18%   91.48%   +0.29%     
==========================================
  Files          51       52       +1     
  Lines        2792     2866      +74     
  Branches      286      297      +11     
==========================================
+ Hits         2546     2622      +76     
+ Misses        147      140       -7     
- Partials       99      104       +5
Impacted Files Coverage Δ
etcd3/errors/errors.py 100% <ø> (ø) ⬆️
etcd3/stateful/lock.py 82.81% <100%> (+0.08%) ⬆️
tests/conftest.py 100% <100%> (ø)
etcd3/client.py 87.38% <100%> (+0.23%) ⬆️
etcd3/errors/__init__.py 100% <100%> (ø) ⬆️
etcd3/utils.py 91.66% <20%> (-8.34%) ⬇️
etcd3/aio_client.py 77.84% <75%> (-0.36%) ⬇️
etcd3/stateful/watch.py 88.23% <86.15%> (+4.43%) ⬆️
tests/test_watch_util.py 95.97% <95.65%> (-0.77%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56adfea...0de182d. Read the comment docs.

@Revolution1 Revolution1 merged commit 2262636 into master Apr 17, 2019
@Revolution1 Revolution1 deleted the fix-watch-util-issue-18-and-78 branch April 17, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants