Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle null value as gogoproto does while modelizing response data #87

Merged
merged 1 commit into from
May 7, 2019

Conversation

Revolution1
Copy link
Owner

fix #74

@Revolution1
Copy link
Owner Author

@pjz

@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #87 into master will increase coverage by 0.03%.
The diff coverage is 91.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   91.48%   91.52%   +0.03%     
==========================================
  Files          52       52              
  Lines        2866     2878      +12     
  Branches      297      298       +1     
==========================================
+ Hits         2622     2634      +12     
- Misses        140      142       +2     
+ Partials      104      102       -2
Impacted Files Coverage Δ
tests/test_kv_apis.py 100% <100%> (ø) ⬆️
etcd3/models.py 100% <100%> (ø) ⬆️
etcd3/stateful/watch.py 88.23% <100%> (ø) ⬆️
etcd3/swagger_helper.py 79.6% <100%> (+1.34%) ⬆️
tests/test_swagger_helper.py 100% <100%> (ø) ⬆️
etcd3/utils.py 86.27% <16.66%> (-5.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2262636...2928205. Read the comment docs.

@Revolution1 Revolution1 merged commit e305fd4 into master May 7, 2019
@Revolution1 Revolution1 deleted the fix/default-0-when-int-value-is-null branch May 7, 2019 10:08
@Revolution1 Revolution1 changed the title add handel null value as gogoproto does while modelizing response data handle null value as gogoproto does while modelizing response data May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.range(..., count_only=True) returns a count of None if no matching keys found; should be 0
1 participant