Fixed the apigateway__enum module #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If the user has "GET" permissions on API Gateways but not the API Keys, the module will still get all the paths from the Gateway rather than failing - There was no error handling on "all regions" so it would fail. Added error handling so the user can check all regions without issues - Previously it saved the data to a standalone file, updated this so it stores to the Pacu DB like other modules
DaveYesland
reviewed
Jun 4, 2024
| print = pacu.print | ||
| session = pacu.get_active_session() | ||
| session = pacu_main.get_active_session() | ||
| print = pacu_main.print | ||
| args = parser.parse_args(args) | ||
|
|
||
| outfile_path = downloads_dir()/'apigateway' |
There was a problem hiding this comment.
We should remove all file output stuff if this data is now saved in the DB
There was a problem hiding this comment.
Stand by, I think I missed something on the database. Digging into this now and will also fix this
There was a problem hiding this comment.
@DaveYesland -- This should all be fixed now
- I broke error handling in my last commit when targeting multiple regions -- this fixes that
DaveYesland
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has "GET" permissions on API Gateways but not the API Keys, the module will still get all the paths/methods/resources rather than failing
There was no error handling on "all regions" so it would fail. Added error handling so the user can check all regions without issues
Previously it saved the data to a standalone file, updated this so it stores to the Pacu DB like other modules