Added firmware version to local UI #35 #43
Conversation
|
I also updated the README.md based on my experience setting up.
|
modules/ribbit/golioth/__init__.py
Outdated
| @@ -43,6 +45,7 @@ | |||
| CONFIG_GOLIOTH_USER, | |||
| CONFIG_GOLIOTH_PASSWORD, | |||
| CONFIG_GOLIOTH_OTA_ENABLED, | |||
| CONFIG_GOLIOTH_FIRMWARE_VERSION, | |||
There was a problem hiding this comment.
I don't think this makes sense as a config key. These are meant for things that can be set from the outside.
Maybe add the version to /api/sensors instead?
There was a problem hiding this comment.
Thanks @damz , that makes more sense. I pushed that change.
| @@ -57,13 +57,18 @@ $ make build | |||
|
|
|||
| Connect the esp32 board to your computer using the USBC connection port on the esp32 and a cable that will connect to your computer. | |||
|
|
|||
| Press and hold the "boot" button then press the "reset" button and release both at the same time (shown below). This puts the esp32 into a flashing mode. | |||
| Press and hold the "boot" button, then press and release the "reset" button, then release the "boot" button (shown below). This puts the esp32 into a flashing mode. If done correctly, the lights should turn off. | |||
There was a problem hiding this comment.
That last part is not technically true. I have the same experience that the CHG LED tends to flicker in normal mode, and to be solid off in DFU mode, but it is not actually designed to do that.
The CHG LED flickers because it has no battery connected to it. It is not clear why it stops when entering DFU mode, but in any case, with a charged battery connected it would be off in both cases.
There was a problem hiding this comment.
Ah ok. Is there any other reliable indicator of when it's in DFU mode?
There was a problem hiding this comment.
Hey @keerats7 ! As it mentions above, you will see the sensor power lights turn off. The device will also enumerate differently to the system. Something like ttymodem etc instead of frogsensor.
There was a problem hiding this comment.
Hey @keenanjohnson , based on @damz comment it seems the CHG LED on the ESP32 may turn off, but that's unrelated to it being in DFU mode. Are you saying the green sensor lights will always turn off when in DFU mode? If so I can add that distinction that specifically the sensor lights will turn off.
This is correct. You need the |
There might be a better way to organize these changes, let me know any suggestions!