Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fs null fallback #45

Merged
merged 7 commits into from
May 24, 2024
Merged

Add fs null fallback #45

merged 7 commits into from
May 24, 2024

Conversation

afonsojramos
Copy link
Contributor

@afonsojramos afonsojramos commented Aug 25, 2023

As there is no fallback to fs I am adding it as false, as I believe all that people want is just to have these defaults so that one does not need to configure all of these fallbacks manually.
Resolves #41, #29, #32, #26.

@nitpum
Copy link

nitpum commented Feb 21, 2024

Merge this, please

@ReiiYuki
Copy link

This MR is very helpful why this hasn't merged yet?

@afonsojramos
Copy link
Contributor Author

@Richienb can we merge this? 👀

@Richienb
Copy link
Owner

Richienb commented Apr 9, 2024

Wait what does fs: false do?

@afonsojramos
Copy link
Contributor Author

It disables fs on the browser, because there is no polyfill for the filesystem.

@Richienb
Copy link
Owner

It disables fs on the browser, because there is no polyfill for the filesystem.

What happens when fs is imported in the browser then? Does it return undefined?

@Richienb Richienb changed the title Add fs fallback Add fs null fallback May 24, 2024
@afonsojramos
Copy link
Contributor Author

Thanks @Richienb!

…` modules by default; rename `includeAliases` to `additionalAliases`, and allow ignoring the defaults with `onlyAliases`

Fixes #40, fixes #52, fixes #18, fixes #44

Signed-off-by: Richie Bendall <[email protected]>
@Richienb Richienb merged commit 010fc94 into Richienb:main May 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Req]: Can we include fs module polyfill to the plugin?
4 participants