Skip to content

Commit

Permalink
Add tooltip popup as a child of p_target to avoid jitter
Browse files Browse the repository at this point in the history
Previously the tooltip popup was added as a child of the `p_target`
viewport (usually the root window), which caused the root window to
recalculate the window size, which could cause jitter issues on i3wm
if the actual width of the root window was less than `1024`.
  • Loading branch information
Rindbee committed Oct 14, 2024
1 parent 92e51fc commit 5c45a64
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion editor/editor_help.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3868,7 +3868,7 @@ void EditorHelpBitTooltip::show_tooltip(EditorHelpBit *p_help_bit, Control *p_ta
EditorHelpBitTooltip *tooltip = memnew(EditorHelpBitTooltip(p_target));
p_help_bit->connect("request_hide", callable_mp(tooltip, &EditorHelpBitTooltip::_safe_queue_free));
tooltip->add_child(p_help_bit);
p_target->get_viewport()->add_child(tooltip);
p_target->add_child(tooltip);
p_help_bit->update_content_height();
tooltip->popup_under_cursor();
}
Expand Down

0 comments on commit 5c45a64

Please sign in to comment.