Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cookie support for all rippers #1483

Merged
merged 5 commits into from
Dec 3, 2019
Merged

Add cookie support for all rippers #1483

merged 5 commits into from
Dec 3, 2019

Commits on Nov 10, 2019

  1. Add cookie support for all rippers

    @xarantolus
    xarantolus committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    227161b View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2019

  1. Use the passed url in cookiesForURL function 

    While this doesn't make any difference, not using the argument is kind of bad.
One could also remove the argument and use `this.url` directly.
    @xarantolus
    xarantolus committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    7fe3ce0 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2019

  1. Warn users about possibly fixable permission error

    @xarantolus
    xarantolus committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    152d6f6 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2019

  1. Add a logging statement if cookies were added to a request

    @xarantolus
    xarantolus committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    6c330c6 View commit details
    Browse the repository at this point in the history

  2. String comparisons: don't use "reference equality" 

    See https://stackoverflow.com/q/513832 for more details
    @xarantolus
    xarantolus committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    74bfac0 View commit details
    Browse the repository at this point in the history