Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SankakuComplexRipper now downloads full sized images #328

Merged
merged 1 commit into from
Dec 11, 2017

Conversation

cyian-1756
Copy link
Collaborator

@cyian-1756 cyian-1756 commented Dec 9, 2017

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

The ripper now downloads tehe full sized images

Testing

Required verification:

  • [X ] I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@coveralls
Copy link

coveralls commented Dec 9, 2017

Coverage Status

Coverage increased (+0.04%) to 31.886% when pulling 46378e1 on cyian-1756:docs into 94f66d3 on RipMeApp:master.

@metaprime metaprime merged commit 57a5368 into RipMeApp:master Dec 11, 2017
@cyian-1756 cyian-1756 deleted the docs branch December 11, 2017 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chan.sankakucomplex is only downloading preview images
3 participants