set export_defined_variables=False and add TODO comment about exploit…

…ing this later
Robbybp · Dec 12, 2023 · 682e054 · 682e054
1 parent 45eb861
commit 682e054
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pyomo/contrib/incidence_analysis/incidence.py b/pyomo/contrib/incidence_analysis/incidence.py
@@ -83,7 +83,10 @@ def _get_incident_via_ampl_repn(expr, linear_only):
     var_map = {}
     used_named_expressions = set()
     symbolic_solver_labels = False
-    export_defined_variables = True
+    # TODO: Explore potential performance benefit of exporting defined variables.
+    # This likely only shows up if we can preserve the subexpression cache across
+    # multiple constraint expressions.
+    export_defined_variables = False
     sorter = FileDeterminism_to_SortComponents(FileDeterminism.ORDERED)
     visitor = AMPLRepnVisitor(
         text_nl_template,