Merge pull request #47 from Roblox/trim_env_vars

Trim Env Vars
Roblox · Feb 22, 2021 · 1bee27d · 1bee27d
2 parents f8232d1 + c88071f
commit 1bee27d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/iis/iis.go b/iis/iis.go
@@ -352,7 +352,8 @@ func applyAppPoolEnvVars(appPoolName string, envVars map[string]string) error {
 	properties := []string{"set", "config", "-section:system.applicationHost/applicationPools"}
 
 	for key, val := range envVars {
-		if strings.Trim(key, " ") == "" {
+		key = strings.Trim(key, " ")
+		if key == "" {
 			continue
 		}
 		if keyExists, isSameValue := doesAppPoolEnvVarExistWithSameValue(appPool, key, val); keyExists {

diff --git a/iis/iis_test.go b/iis/iis_test.go
@@ -299,6 +299,7 @@ func TestWebsite(t *testing.T) {
 			"EXAMPLE_ENV_VAR_ALT": "test123",
 			"":                    "INVALID",
 			"   ":                 "INVALID_SPACE",
+			" FUN_SPACE ":         "test456",
 		},
 		AppPoolIdentity: iisAppPoolIdentity{
 			Identity: "SpecificUser",
@@ -340,6 +341,7 @@ func TestWebsite(t *testing.T) {
 			expectedAppPoolEnvVars := []appPoolAddEnvVar{
 				{Name: "EXAMPLE_ENV_VAR", Value: "test123"},
 				{Name: "EXAMPLE_ENV_VAR_ALT", Value: "test789"},
+				{Name: "FUN_SPACE", Value: "test456"},
 			}
 
 			assert.ElementsMatch(expectedAppPoolEnvVars, appPool.Add.EnvironmentVariables.Add, "AppPool EnvironmentVariables don't match!")