Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Abs File Paths Bug #48

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Fix Abs File Paths Bug #48

merged 1 commit into from
Feb 26, 2021

Conversation

Vulfox
Copy link
Contributor

@Vulfox Vulfox commented Feb 26, 2021

Such a silly bug on my part. I feel embarrassed. This is a callout to needing better integration/driver mock tests. Another issue addresses this #39 .

Fix #42

@Vulfox Vulfox added the code review code review label Feb 26, 2021
@Vulfox Vulfox self-assigned this Feb 26, 2021
@github-actions
Copy link

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@shishir-a412ed shishir-a412ed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vulfox Vulfox merged commit 064f7a0 into master Feb 26, 2021
@Vulfox Vulfox deleted the abs_path branch February 26, 2021 20:40
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2021
@Vulfox Vulfox added this to the 0.2.0 Release milestone Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
code review code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site Path is Empty
2 participants