Add extra argument to thunk middleware #69
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
tonycuadra
changed the title
There was a problem hiding this comment.
This looks reasonable to me! Could you update the docs as well? There's already info on the thunk middleware: https://roblox.github.io/rodux/api-reference/#roduxthunkmiddleware
You can label it as "unreleased" if you like, and we can change it when we cut a new version.
Done! |
|
I don't have permission to do much of anything in this repo so please merge when ready @ZoteTheMighty :) |
Or add more reviewers if needed (I can't do that either) |
This feature is equivalent to what is available in newer versions of Redux: https://github.com/reduxjs/redux-thunk#injecting-a-custom-argument It allows arbitrary parameters to injected into thunks via a table passed in at Rodux initialization time (useful for passing in services or anything else we might want to mock for tests). It can replace other custom middlewares we've written to achieve the same thing (e.g. PaginatedFetchThunk.middleware, AvatarEditorServiceThunk.middleware, RNAdapterThunk.middleware)
* Add extra argument to thunk middleware (#69) This feature is equivalent to what is available in newer versions of Redux: https://github.com/reduxjs/redux-thunk#injecting-a-custom-argument It allows arbitrary parameters to injected into thunks via a table passed in at Rodux initialization time (useful for passing in services or anything else we might want to mock for tests). It can replace other custom middlewares we've written to achieve the same thing (e.g. PaginatedFetchThunk.middleware, AvatarEditorServiceThunk.middleware, RNAdapterThunk.middleware) * Make it 3.2 * oops
This feature is equivalent to what is available in newer versions of Redux:
https://github.com/reduxjs/redux-thunk#injecting-a-custom-argument
It allows arbitrary parameters to injected into thunks via a table passed in at Rodux initialization time (useful for passing in services or anything else we might want to mock for tests).
It can replace other custom middlewares we've written to achieve the same thing (e.g. PaginatedFetchThunk.middleware, AvatarEditorServiceThunk.middleware, RNAdapterThunk.middleware)