Filter Release Tags #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoteTheMighty
approved these changes
Nov 2, 2023
| { | ||
| tag_name: "4.3.0", | ||
| assets: [] | ||
| } |
There was a problem hiding this comment.
Just for good measure, can we add one that starts with v but isn't valid? 😀
| function filterValidReleases(releases: GitHubRelease[]): GitHubRelease[] { | ||
| return releases.filter(release => { | ||
| const tag = release.tag_name; | ||
| return tag.startsWith("v") && semver.valid(tag); |
There was a problem hiding this comment.
I assume that semver.valid must handle the leading v just fine, since your tests appear to pass
ZoteTheMighty
approved these changes
Nov 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior is for setup-foreman to fail if it encounters an invalid semver tag in the Foreman repo. This PR looks to
add a filter step to filter out invalid semver tags.