Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to python3 #521

Closed
wants to merge 4 commits into from

Conversation

patmarion
Copy link
Member

No description provided.

@patmarion
Copy link
Member Author

fyi @rdeits I made this fix when updating to python 3:

e868cce

You might consider changing the data field of viewer2_comms_t from bytes to string type:

https://github.com/RobotLocomotion/lcmtypes/blob/master/lcmtypes/viewer2_comms_t.lcm#L16

@rdeits
Copy link
Contributor

rdeits commented Jun 14, 2017

Ok, thanks!

@EricCousineau-TRI
Copy link
Contributor

@patmarion Can I ask if which branch has the most recent Python 3 updates for director?

And I can I ask if you've decided on just moving over to Python 3, dropping Python 2 development?

If it helps at all, here's my very brief investigation into looking at what Python 3 + ROS 1 looks like:
RobotLocomotion/drake#10606 (comment) (summary: complicated)

\cc @jamiesnape

@patmarion
Copy link
Member Author

Hi Eric, the most recent python3 development branch is:

https://github.com/patmarion/director/tree/update-mac-build

I have a PR for it here:

#625

And the most recent travis-ci for that PR was all green for ubuntu 16.04, ubuntu 18.04, and mac (xcode 10.2):

https://travis-ci.org/RobotLocomotion/director/builds/552278930

The branch is named "update-mac-build" but that's a bad name, sorry! The branch contains the python3 upgrade, and fixes the build for ubuntu 18, vtk 8, and latest mac homebrew.

I've been busy with other things and so I haven't proceeded with landing this branch to master. But I use this branch as my primary working copy.

@patmarion
Copy link
Member Author

This is now the latest PR for python3 into director/master: #625

@patmarion patmarion closed this Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants