-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to python3 #521
Update to python3 #521
Conversation
af198d7
to
e868cce
Compare
fyi @rdeits I made this fix when updating to python 3: You might consider changing the data field of viewer2_comms_t from bytes to string type: https://github.com/RobotLocomotion/lcmtypes/blob/master/lcmtypes/viewer2_comms_t.lcm#L16 |
Ok, thanks! |
d02c608
to
8585411
Compare
8585411
to
62d0f18
Compare
62d0f18
to
12074b3
Compare
0146bf6
to
7d0e3fd
Compare
7d0e3fd
to
8343c9c
Compare
8343c9c
to
64fb922
Compare
64fb922
to
4459471
Compare
@patmarion Can I ask if which branch has the most recent Python 3 updates for And I can I ask if you've decided on just moving over to Python 3, dropping Python 2 development? If it helps at all, here's my very brief investigation into looking at what Python 3 + ROS 1 looks like: \cc @jamiesnape |
Hi Eric, the most recent python3 development branch is: https://github.com/patmarion/director/tree/update-mac-build I have a PR for it here: And the most recent travis-ci for that PR was all green for ubuntu 16.04, ubuntu 18.04, and mac (xcode 10.2): https://travis-ci.org/RobotLocomotion/director/builds/552278930 The branch is named "update-mac-build" but that's a bad name, sorry! The branch contains the python3 upgrade, and fixes the build for ubuntu 18, vtk 8, and latest mac homebrew. I've been busy with other things and so I haven't proceeded with landing this branch to master. But I use this branch as my primary working copy. |
This is now the latest PR for python3 into director/master: #625 |
No description provided.