Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autopybind: Should test current workflows for automated bindings #14827

Closed
7 tasks
EricCousineau-TRI opened this issue Mar 25, 2021 · 6 comments
Closed
7 tasks
Assignees
Labels
component: pydrake Python API and its supporting Starlark macros configuration: python unused team: kitware

Comments

@EricCousineau-TRI
Copy link
Contributor

EricCousineau-TRI commented Mar 25, 2021

As part of #7889, using #14265 (now #15205)

I've chosen the following symbols to genuinely try this workflow out on:

  • New bindings:
    • Non-templated:
    • Templated:
      • drake::systems::sensors::Accelerometer
      • drake::systems::PortSwitch
  • Update bindings
    • Non-templated:
      • drake::solvers::MixedIntegerBranchAndBound
    • Templated:
      • drake::systems::SurfaceMesh
      • drake::multibody::MultibodyPlant
@EricCousineau-TRI
Copy link
Contributor Author

FYI @josephsnyder

@EricCousineau-TRI
Copy link
Contributor Author

My plan is to make the PR, but will strive to record what was necessary to go from generated bindings to my own liking as well as reviewer acceptance.

@EricCousineau-TRI
Copy link
Contributor Author

EricCousineau-TRI commented Mar 26, 2021

For RenderEngineGlParams, see commits 56700ca and bde2a42 for final products.
Branch: https://github.com/EricCousineau-TRI/drake/tree/issue-14827-wip

@jamiesnape and @josephsnyder I've added opinionated steps that I took here to make initial state of #14828:
https://github.com/RobotLocomotion/drake/blob/56700ca7a4/tools/autopybind/README.md#steps-taken

Can both of you please review my steps here and let me know if there is anything better that I could have done?
I will file an issue about adding an option to suppress warnings (done), and possibly provide more user-friendly errors if a symbol isn't found in a file (I don't know how to request this).

Given current workflow for a simple case, I would still like to wait until certain parts of the denoising happen before asking anyone else to run this.

@EricCousineau-TRI
Copy link
Contributor Author

Tried drake::multibody::StaticEquilibriumConstraint. Punted because of weird API (our fault), but there were still pain points w.r.t. autopybind11:
https://github.com/EricCousineau-TRI/drake/blob/f25751c7ca64755e55ade1ae10073937b25aeb5b/tools/autopybind/README.md#for-staticequilibriumconstraint

@EricCousineau-TRI
Copy link
Contributor Author

I'm pausing any more of my effort on this until denoising lands.

@jwnimmer-tri
Copy link
Collaborator

Closing out as "unlikely to reach an actionable state within a reasonable timeframe".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pydrake Python API and its supporting Starlark macros configuration: python unused team: kitware
Projects
None yet
Development

No branches or pull requests

2 participants