-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "mechanical reduction" in MultibodyPlant urdf parser #21948
Comments
<motorInertai>
in MultibodyPlant urdf parser<motorInertia>
in MultibodyPlant urdf parser
I might not understand what you're saying here. Is your impression that this is a standard URDF element? I looked through https://wiki.ros.org/urdf/XML and couldn't find it specified anywhere. If you have a pointer to its spec, that would would help unblock. |
Oh. You're right. I linked to the urdf spec for mechanicalReduction, and assumed that the other tag was juxtaposed. Ok, I think leaving |
<motorInertia>
in MultibodyPlant urdf parser
To my knowledge, URDF has never had any sort of change control or release process. By contrast, SDFormat has spec versions, with defined content. I would agree with Nimmer's idea that the web site is the closest thing we will get to a spec. Still there are files out there in the wild with all sorts of variations of I don't disagree that an argument could be made for accepting more variations of URDF files. That is work we could choose to do. I'm not sure that finding some alternate construction in the wild that overlaps with a drake extension automatically means we should deprecate the drake extension. |
@rpoyner-tri -- |
I interpreted Rico's comment as only scoped to In any case, I think it's good to keep this ticket scoped to only be about accepting a non-unity |
Reading the docs pointed to by @RussTedrake, I do not understand what the purpose of the
Altogether, I do not yet understand what the requested feature is. |
My understanding is that The user would still say |
@amcastro-tri -- yes, as I've said repeatedly (#20993), I believe most people model actuator input in motor coordinates, not joint coordinates. I won't restart that battle again here; but I do believe that the existence of only mechanical reduction w/o rotor inertia in the urdf spec does support my point. |
I've found myself wanting to parse a urdf that has actuators specified with a
<mechanicalReduction>
tag whose value is far from 1. The URDF parser current warnsIn fact, I think we added support for gear ratios in #14167.
The urdf actuators also have a<motorInertia>
specified. These tags are silently ignored.More bizarre, we actually do support these things, but via custom
<drake:rotor_inertia>
and<drake:gear_ratio>
tags.drake/multibody/parsing/detail_urdf_parser.cc
Lines 832 to 860 in 8c7133c
Is it possible that the urdf spec changed since we added these?
My ask is that we do support the real urdf tags.
Possibly we can/should deprecate the drake custom tags and update any urdfs that we've authored with them?
cc @joemasterjohn who authored the initial support.
The text was updated successfully, but these errors were encountered: