Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD file in drake-distro root conflicts with "from source" instructions #4693

Closed
RussTedrake opened this issue Jan 5, 2017 · 9 comments
Closed
Assignees
Labels
component: distribution Nightly binaries, monthly releases, docker, installation configuration: mac priority: high

Comments

@RussTedrake
Copy link
Contributor

Just went to make a fresh build from master on a different (mac) laptop, and hit this one.

31-34-10% cd drake-distro
31-34-10% mkdir build
mkdir: build: File exists

nice. i can't actually create a build directory right now. and given some assumptions in our cmake files (#4606), I can't name it something else.

@RussTedrake RussTedrake added configuration: mac priority: high component: distribution Nightly binaries, monthly releases, docker, installation labels Jan 5, 2017
@SeanCurtis-TRI
Copy link
Contributor

Hard to imagine where the build folder came from; it doesn't appear in master.

@sherm1
Copy link
Member

sherm1 commented Jan 5, 2017

There is, OTOH, a file named BUILD in master. Is this possibly a platform where file names are case-insensitive so that BUILD and build name the same file?

@RussTedrake
Copy link
Contributor Author

I'm sorry. I thought all of that was implied. Yes -- on mac the filenames are case insensitive, so the existence of the BUILD file in drake-distro disallows the creation of a build directory.

@jamiesnape
Copy link
Contributor

Just hit that myself today. All our infrastructure uses a directory called build so it is somewhat of an issue. OS X CI builds delete BUILD (they assume it was a left over build directory).

@jamiesnape
Copy link
Contributor

This may also be what is caused the update column of CDash to turn red for OS X builds.

@jwnimmer-tri
Copy link
Collaborator

Understood. I should be able to get a work-around PR in tonight. Local work-around would be to build using CMake (with rm BUILD; mkdir build) xor Bazel.

@jwnimmer-tri
Copy link
Collaborator

Is there a reasonably cost-effective way we could have made CI find this for us (even post-merge / nightly)?

@jwnimmer-tri
Copy link
Collaborator

Directly on point: bazelbuild/bazel#552.

@jamiesnape
Copy link
Contributor

jamiesnape commented Jan 6, 2017

Is there a reasonably cost-effective way we could have made CI find this for us (even post-merge / nightly)?

It is tricky because cleaning the build directory was itself a safety feature in case removal of the workspace from the previous build failed. CDash did pick up that something was wrong, but we do not currently consider failures computing the changelog an error. I will give it some thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: distribution Nightly binaries, monthly releases, docker, installation configuration: mac priority: high
Projects
None yet
Development

No branches or pull requests

5 participants