Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for delay_between_messages CLI argument #177

Merged

Conversation

jtrautmann
Copy link

Fixes #176

Copy link
Member

@minggangw minggangw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR, would you also add the description for this new option, see

.option('-p, --port [port_number]', 'Listen port, default to :9090')
.option('-a, --address [address_string]', 'Remote server address (client mode); server mode if unset')
.option('-r, --retry_startup_delay [delay_ms]', 'Retry startup delay in millisecond')
.option('-o, --fragment_timeout [timeout_ms]', 'Fragment timeout in millisecond')
.option('-d, --delay_between_messages [delay_ms]', 'Delay between messages in millisecond')

@minggangw
Copy link
Member

My bad, it's already there, please ignore my previous comment. LGTM!

@minggangw minggangw merged commit dae5dae into RobotWebTools:develop Feb 24, 2021
@jtrautmann jtrautmann deleted the add-delay-between-messages-support branch February 24, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for delay_between_messages parameter
2 participants