Fix action cancelation in rosbridge library #952
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
N/A
Description
This PR sort of handles goal cancellation by aborting goals when a cancel request is sent. Somehow actual canceling won't work and I'm drawing a blank on how to fix this properly. Might require a more sweeping change, but I give up for now.
If someone wants this PR, they can try it.
(maybe?) Closes #920