Refactor raytrace node configurations and introduce non-hit distance handling #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebraszka
changed the title
nebraszka
changed the title
nebraszka
force-pushed
the
mn/raytrace-configurations
branch
3 times, most recently
from
9bbfcc4
to
67e5d88
Compare
msz-rai
requested changes
Feb 29, 2024
|
+ Please rebase PR onto the latest |
Co-authored-by: Mateusz Szczygielski <[email protected]>
nebraszka
force-pushed
the
mn/raytrace-configurations
branch
2 times, most recently
from
4960c4b
to
aa22f09
Compare
nebraszka
force-pushed
the
mn/raytrace-configurations
branch
from
aa22f09
to
cf763c2
Compare
msz-rai
requested changes
Mar 4, 2024
nebraszka
force-pushed
the
mn/raytrace-configurations
branch
from
cf0e14a
to
ae8df93
Compare
msz-rai
approved these changes
Mar 5, 2024
msz-rai
added a commit
that referenced
this pull request
Jun 11, 2024
…handling (#257) * Add prototype of rgl_node_raytrace_configure_velocity * Add prototype of tape_node_raytrace_configure_velocity * Add invalid_node_object test * Add prototype of rgl_node_raytrace_configure_distortion * Add documentation * Refactor usage of raytrace in motion & with distortion * Changes in the api documentation * Add prototype of raytrace_configure_non_hit_distance_values * Add prototype of raytrace_configure_non_hit_distance_values * Finish implementation and tests * Apply suggestions from code review Co-authored-by: Mateusz Szczygielski <[email protected]> * Review fixes * Re-review fixes --------- Co-authored-by: Mateusz Szczygielski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.