Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mediators for Game Object Containers #55

Merged
merged 66 commits into from
Sep 10, 2018

Conversation

gnunua
Copy link
Contributor

@gnunua gnunua commented Sep 7, 2018

Description

  • add mediators for Phaser.GameObject.Container
  • example app update
  • update tests

Related Issue

Here is the related issue #54

Motivation and Context

Managing all views directly form the scene mediators is complex.

How Has This Been Tested?

Testing withe example app

Types of changes

  • Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation. ( has been updated changedlog and readme)
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@saqsun saqsun assigned saqsun and unassigned saqsun Sep 7, 2018
@saqsun saqsun self-requested a review September 7, 2018 11:03
Copy link
Contributor

@saqsun saqsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@tiagoschenkel
Copy link
Member

Nice contribution @gnunua!

I added some suggestions to the Changelog that can be covered in future pull requests.

Closes #54.

@tiagoschenkel tiagoschenkel merged commit 7ab7609 into RobotlegsJS:master Sep 10, 2018
@tiagoschenkel tiagoschenkel requested review from tiagoschenkel and removed request for tiagoschenkel September 10, 2018 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants