Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Hide Jitsi Logs using showLogs props #132

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

samad-yar-khan
Copy link
Contributor

@samad-yar-khan samad-yar-khan commented Apr 5, 2022

Issues

Mentioned in the issue #131

Proposed changes (including videos or screenshots)

  • Add showLogs props top <Jitsibroadcaster ... /> component which can be set to true to view logs and false to hide logs
2022-04-06.12-32-42.mp4

@lgtm-com
Copy link

lgtm-com bot commented Apr 5, 2022

This pull request introduces 1 alert when merging d7bcd4c into 4db8216 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 5, 2022

This pull request introduces 1 alert when merging 8971a74 into 4db8216 - view on LGTM.com

new alerts:

  • 1 for Use of returnless function

@@ -39,6 +39,9 @@ const Jitsibroadcaster = ({ room, disName, rtmpSrc, handleChat }) => {
{ speaker: "Z", hour: "50" },
];

//Set "showLogs" to true if you want to see logs for debugging
const showLogs = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

showLogs shouldn't be a constant in the components code!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sing-Li I have changed the approach. The logs can now be toggled using a button in the dropdown.

@samad-yar-khan samad-yar-khan changed the title [FIX] Hide Jitsi Logs [FIX] Toggle Jitsi Logs Apr 5, 2022
@samad-yar-khan samad-yar-khan changed the title [FIX] Toggle Jitsi Logs [FIX] Hide Jitsi Logs Apr 5, 2022
@samad-yar-khan samad-yar-khan changed the title [FIX] Hide Jitsi Logs [FIX] oggle Jitsi Logs Apr 5, 2022
@samad-yar-khan samad-yar-khan changed the title [FIX] oggle Jitsi Logs [FIX] Toggle Jitsi Logs Apr 5, 2022
@samad-yar-khan samad-yar-khan changed the title [FIX] Toggle Jitsi Logs [FIX] Hide Jitsi Logs using showLogs props Apr 6, 2022
@Sing-Li Sing-Li added this to the GSoC 2022 Alumni Summit milestone May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants