Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW][β] IPFS snapshot component #151

Merged
merged 8 commits into from
Jun 24, 2022
Merged

[NEW][β] IPFS snapshot component #151

merged 8 commits into from
Jun 24, 2022

Conversation

Dnouv
Copy link
Member

@Dnouv Dnouv commented Apr 25, 2022

This PR adds an IPFS component to get a CID for uploaded media.

Related: #144

Thank you!

@lgtm-com
Copy link

lgtm-com bot commented Apr 25, 2022

This pull request introduces 1 alert when merging f03e24b into df318b4 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 25, 2022

This pull request introduces 1 alert when merging d99db43 into df318b4 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Copy link
Member

@Sing-Li Sing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please integrate the camera (via browser API) to capture the "snapshot"

@Dnouv
Copy link
Member Author

Dnouv commented Apr 26, 2022

Thanks a lot for the review, sure I will integrate the camera.

@lgtm-com
Copy link

lgtm-com bot commented May 4, 2022

This pull request introduces 6 alerts when merging 11b13d6 into df318b4 - view on LGTM.com

new alerts:

  • 6 for Unused variable, import, function or class

@Dnouv Dnouv marked this pull request as ready for review May 4, 2022 14:52
@lgtm-com
Copy link

lgtm-com bot commented May 4, 2022

This pull request introduces 1 alert when merging ebe1e18 into df318b4 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@Dnouv Dnouv changed the title [NEW][α] IPFS snapshot component [NEW][β] IPFS snapshot component May 4, 2022
@Sing-Li
Copy link
Member

Sing-Li commented May 23, 2022

Please resolve conflicts and update to volta dependencies and it should be ready to merge. Thanks.

@Sing-Li Sing-Li merged commit b142610 into RocketChat:master Jun 24, 2022
Dnouv added a commit to Dnouv/RC4Community that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants