Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLP] Remove firebase Auth #191

Merged
merged 3 commits into from
Oct 31, 2022
Merged

[CLP] Remove firebase Auth #191

merged 3 commits into from
Oct 31, 2022

Conversation

Dnouv
Copy link
Member

@Dnouv Dnouv commented Oct 31, 2022 •
edited
Loading

Changes in the PR:

  • Reverts the Firebase implementation merge commit
  • Updates the package-lock

Why did this change?

  • Reverting to resolve the dependency conflicts that occurred while updating NextJS
  • Since the package-lock was committed in the PR([WIP] Firebase Auth Component #48 ) implementing the Firebase Auth, we should update it to the latest

Thank you!

@Sing-Li Sing-Li merged commit 7241ded into RocketChat:master Oct 31, 2022
Dnouv added a commit to Dnouv/RC4Community that referenced this pull request Nov 3, 2022
@Dnouv
[CLP] Remove firebase Auth (RocketChat#191)
eaabff5 
* Revert "Add  Firebase Auth Component (RocketChat#48)"

This reverts commit 65d5d88.

* revert done

* remove other firebase components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dnouv @Sing-Li