Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Discussion Builder #250

Merged
merged 11 commits into from
Apr 14, 2020
Merged

Adds Discussion Builder #250

merged 11 commits into from
Apr 14, 2020

Conversation

marceloschmidt
Copy link
Member

What? ⛵

Added Discussion Builder

Why? 🤔

Allows apps to create discussions

@marceloschmidt
Copy link
Member Author

marceloschmidt commented Mar 27, 2020 •
edited by sampaiodiego
Loading

This is related to RocketChat/Rocket.Chat#16683

@codecov
Copy link

codecov bot commented Mar 27, 2020 •
edited
Loading

Codecov Report

Merging #250 into beta will decrease coverage by 0.59%.
The diff coverage is 44.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             beta     #250      +/-   ##
==========================================
- Coverage   53.81%   53.21%   -0.60%     
==========================================
  Files          70       74       +4     
  Lines        2568     2702     +134     
  Branches      380      398      +18     
==========================================
+ Hits         1382     1438      +56     
- Misses       1186     1264      +78
Impacted Files Coverage Δ
src/server/managers/AppListenerManager.ts 4.29% <0.00%> (-0.28%) ⬇️
src/server/managers/AppSlashCommandManager.ts 99.38% <ø> (ø)
src/server/rooms/Room.ts 52.94% <ø> (ø)
src/server/accessors/ModifyCreator.ts 56.81% <10.00%> (-14.20%) ⬇️
src/server/accessors/DiscussionBuilder.ts 17.39% <17.39%> (ø)
src/server/AppManager.ts 14.56% <21.42%> (+0.28%) ⬆️
src/server/accessors/UserUpdater.ts 25.00% <25.00%> (ø)
src/server/accessors/ExternalComponentsExtend.ts 50.00% <50.00%> (ø)
src/server/accessors/ModifyUpdater.ts 91.83% <50.00%> (-3.72%) ⬇️
src/server/accessors/RoomBuilder.ts 97.43% <66.66%> (-2.57%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9ca98a...084c197. Read the comment docs.

d-gubert
d-gubert requested changes Mar 28, 2020
View reviewed changes
src/definition/accessors/IModifyCreator.ts Outdated Show resolved Hide resolved
src/server/accessors/ModifyCreator.ts Outdated Show resolved Hide resolved
@shiqimei shiqimei self-assigned this Mar 31, 2020
shiqimei
shiqimei approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@shiqimei shiqimei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your great work!

d-gubert and others added 2 commits April 13, 2020 17:11
@d-gubert
Beta v1.13 (#237)
a917953 
Changes:

* Added External Components API
* New UserUpdater modifier
* Changes to app's default user creation
@d-gubert
1.13.0
d54cec2
@d-gubert d-gubert closed this Apr 14, 2020
@d-gubert
Copy link
Member

Accidentally closed it - I think it was a side effect of deleting the beta branch 🤔

@d-gubert d-gubert reopened this Apr 14, 2020
@d-gubert d-gubert merged commit 27f86ba into beta Apr 14, 2020
@d-gubert d-gubert deleted the discussion-mechanism branch April 14, 2020 18:58
d-gubert added a commit that referenced this pull request Apr 30, 2020
@marceloschmidt @d-gubert
Adds Discussion Builder (#250)
ed445fe 
* Create DiscussionBuilder and related

* Adds DiscussionBuilder and adds createDiscussion

* Add test for createDiscussion

* Apply suggestions from code review

* Make room and discussion builders accept partial arguments

Co-authored-by: Douglas Gubert <[email protected]>
Co-authored-by: Douglas Gubert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-gubert d-gubert d-gubert requested changes

@shiqimei shiqimei shiqimei approved these changes

Assignees

@shiqimei shiqimei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marceloschmidt @d-gubert @shiqimei