Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Missing addCustomField method in MessageBuilder #363

Merged
merged 4 commits into from
Dec 13, 2021

Conversation

matheusbsilva137
Copy link
Member

What? ⛵

  • Added the addCustomField method in the MessageBuilder class so as to allow developers to add custom fields using the messageBuilder object.

Why? 🤔

This PR is introduced in order to make the MessageBuilder class more complete and consistent, it has been built as a solution to the issue #309.

Links 🌎

Issue #309

PS 👀

@CLAassistant
Copy link

CLAassistant commented Jan 11, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #363 (2f57f3a) into alpha (b358174) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha     #363      +/-   ##
==========================================
+ Coverage   53.22%   53.36%   +0.14%     
==========================================
  Files          86       86              
  Lines        2914     2923       +9     
  Branches      412      415       +3     
==========================================
+ Hits         1551     1560       +9     
  Misses       1363     1363              
Impacted Files Coverage Δ
src/server/accessors/MessageBuilder.ts 87.38% <100.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b358174...2f57f3a. Read the comment docs.

Copy link
Contributor

@graywolf336 graywolf336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially a missing error check. And can you cover the new lines in the tests?

src/server/accessors/MessageBuilder.ts Show resolved Hide resolved
@cuonghuunguyen
Copy link
Contributor

Is there any issue that blocks this PR? It's been here for a very long time

@d-gubert d-gubert changed the title [FIX] Missing addCustomField method in MessageBuilder (#309) [IMPROVE] Missing addCustomField method in MessageBuilder (#309) Dec 13, 2021
@d-gubert d-gubert changed the title [IMPROVE] Missing addCustomField method in MessageBuilder (#309) [IMPROVE] Missing addCustomField method in MessageBuilder Dec 13, 2021
@d-gubert d-gubert merged commit aa7eacf into alpha Dec 13, 2021
@d-gubert d-gubert deleted the custom-fields-message-builder branch December 13, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MessageBuilder should be able to add/set custom fields for message
5 participants