-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] Missing addCustomField method in MessageBuilder #363
Conversation
Codecov Report
@@ Coverage Diff @@
## alpha #363 +/- ##
==========================================
+ Coverage 53.22% 53.36% +0.14%
==========================================
Files 86 86
Lines 2914 2923 +9
Branches 412 415 +3
==========================================
+ Hits 1551 1560 +9
Misses 1363 1363
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially a missing error check. And can you cover the new lines in the tests?
Is there any issue that blocks this PR? It's been here for a very long time |
What? ⛵
addCustomField
method in theMessageBuilder
class so as to allow developers to add custom fields using themessageBuilder
object.Why? 🤔
This PR is introduced in order to make the
MessageBuilder
class more complete and consistent, it has been built as a solution to the issue #309.Links 🌎
Issue #309
PS 👀