Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Typo addMemberToBeAddedByUsername instead of addMemberByUsername #416

Merged

Conversation

aditya-mitra
Copy link
Contributor

What? ⛵

Correct incorrect method name of addMemberByUsername to addMemberToBeAddedByUsername in the JSDoc for addUsername

Why? 🤔

There is no method called addMemberByUsername which wrongly shown here

image

Links 🌎

PS 👀

@CLAassistant
Copy link

CLAassistant commented May 12, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #416 (f1c071d) into alpha (03cc907) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            alpha     #416   +/-   ##
=======================================
  Coverage   48.67%   48.67%           
=======================================
  Files         103      103           
  Lines        3244     3244           
  Branches      476      476           
=======================================
  Hits         1579     1579           
  Misses       1665     1665           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03cc907...f1c071d. Read the comment docs.

@geekgonecrazy geekgonecrazy merged commit bf38889 into RocketChat:alpha Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants