-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: onUpdate
hook for apps
#778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevLehman
commented
Jul 3, 2024
Thanks for this! I just think we're missing here the signature for the method in the |
d-gubert
reviewed
Jul 10, 2024
Example usage: export class ExampleApp extends App {
public async onUpdate(context: IAppUpdateContext, read: IRead, http: IHttp, persistence: IPersistence, modify: IModify): Promise<void> {
console.log("Hello from update", context);
const message = modify.getCreator().startMessage();
const room = await read.getRoomReader().getById("GENERAL");
if (!room) {
throw new Error('oh no');
}
message.setText("Hello, thank you for updating!").setRoom(room);
await modify.getCreator().finish(message);
}
} |
d-gubert
reviewed
Jul 11, 2024
d-gubert
approved these changes
Jul 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? β΅
https://rocketchat.atlassian.net/browse/CONN-289
Added hook to be called when an app is updated
Why? π€
Because why not π€·π½ββοΈ
Serious: allows apps to do stuff only when an update happens, like sending messages or create cron jobs.
Links π
Related PR to get
user
on context: RocketChat/Rocket.Chat#32719PS π