Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Recover minimized/maximized state on show window when unread count changes #1810

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

tassoevan
Copy link
Collaborator

Closes #1590
Closes #1612

BrowserWindow's API doesn't keep "minimized" and "maximized" window states when a hidden window is shown. So, we should forcedly set it again through imperative methods.

@tassoevan tassoevan added this to the 3.0.4 milestone Oct 14, 2020
@tassoevan tassoevan requested a review from a team October 14, 2020 02:31
@tassoevan tassoevan merged commit 15585f2 into master Oct 14, 2020
@tassoevan tassoevan deleted the fix/show-window-on-unread branch October 14, 2020 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rocket.Chat client window resizes on new message Show on unread messages doesn't keep sizing
1 participant