Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: MSI installer #1734

Merged
merged 3 commits into from
Sep 25, 2020
Merged

feat: MSI installer #1734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8dd6743
Add MSI build
tassoevan Sep 23, 2020
3e2709a
Add more explicit build configurations
tassoevan Sep 23, 2020
d4beb51
Update dependencies
tassoevan Sep 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Thumbs.db

/.vscode
/node_modules
/package-lock.json

/app
/dist
Expand Down
28 changes: 26 additions & 2 deletions electron-builder.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,40 @@
},
"win": {
"target": [
"nsis"
"nsis",
"msi"
],
"icon": "build/icon.ico",
"publisherName": "Sectigo RSA Code Signing CA"
"publisherName": "Sectigo RSA Code Signing CA",
"legalTrademarks": "",
"verifyUpdateCodeSignature": true,
"requestedExecutionLevel": "asInvoker",
"signAndEditExecutable": true,
"signDlls": false
},
"nsis": {
"oneClick": false,
"perMachine": false,
"allowElevation": true,
"allowToChangeInstallationDirectory": true,
"installerIcon": "build/installerIcon.ico",
"uninstallerIcon": "build/uninstallerIcon.ico",
"installerSidebar": "build/installerSidebar.bmp",
"uninstallerSidebar": "build/uninstallerSidebar.bmp",
"uninstallDisplayName": "${productName} ${version}",
"include": "build/installer.nsh",
"license": "LICENSE",
"artifactName": "rocketchat-setup-${version}.${ext}",
"deleteAppDataOnUninstall": false,
"displayLanguageSelector": false,
"unicode": true,
"warningsAsErrors": true,
"runAfterFinish": true,
"createDesktopShortcut": "always",
"createStartMenuShortcut": true,
"menuCategory": false
},
"msi": {
"artifactName": "rocketchat-setup-${version}.${ext}"
},
"appx": {
Expand Down
32 changes: 16 additions & 16 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@
"eslint": "eslint src"
},
"dependencies": {
"@bugsnag/js": "^7.3.3",
"@bugsnag/js": "^7.3.5",
"@emotion/core": "^10.0.35",
"@emotion/styled": "^10.0.27",
"@rocket.chat/fuselage": "^0.14.1",
"@rocket.chat/fuselage-hooks": "^0.14.1",
"@rocket.chat/icons": "^0.14.1",
"@rocket.chat/fuselage": "^0.15.1",
"@rocket.chat/fuselage-hooks": "^0.15.1",
"@rocket.chat/icons": "^0.15.1",
"dictionary-de": "^2.0.4",
"dictionary-en": "^3.0.1",
"dictionary-en-gb": "^2.2.2",
Expand All @@ -48,12 +48,12 @@
"dictionary-tr": "^1.3.4",
"electron-hunspell": "^1.1.2",
"electron-store": "^6.0.0",
"electron-updater": "^4.3.4",
"electron-updater": "^4.3.5",
"i18next": "^19.7.0",
"node-fetch": "^2.6.0",
"react": "^16.13.1",
"react-dom": "^16.13.1",
"react-i18next": "^11.7.2",
"react-i18next": "^11.7.3",
"react-keyed-flatten-children": "^1.3.0",
"react-redux": "^7.2.1",
"redux": "^4.0.5",
Expand All @@ -73,14 +73,14 @@
"@jest-runner/electron": "^3.0.0",
"@rocket.chat/eslint-config": "^0.4.0",
"@rollup/plugin-babel": "^5.2.0",
"@rollup/plugin-commonjs": "^15.0.0",
"@rollup/plugin-commonjs": "^15.1.0",
"@rollup/plugin-json": "^4.1.0",
"@rollup/plugin-node-resolve": "^9.0.0",
"@rollup/plugin-replace": "^2.3.3",
"@rollup/plugin-typescript": "^5.0.2",
"@rollup/plugin-typescript": "^6.0.0",
"@types/electron-devtools-installer": "^2.2.0",
"@types/i18next-node-fs-backend": "^2.1.0",
"@types/jest": "^26.0.10",
"@types/jest": "^26.0.14",
"@types/meteor": "^1.4.49",
"@types/node": "^12",
"@types/node-fetch": "^2.5.7",
Expand All @@ -89,27 +89,27 @@
"@types/react-redux": "^7.1.9",
"@types/resize-observer-browser": "^0.1.3",
"@types/rimraf": "^3.0.0",
"@typescript-eslint/eslint-plugin": "^4.0.1",
"@typescript-eslint/parser": "^4.0.1",
"@typescript-eslint/eslint-plugin": "^4.2.0",
"@typescript-eslint/parser": "^4.2.0",
"babel-eslint": "^10.1.0",
"builtin-modules": "^3.1.0",
"chokidar": "^3.4.2",
"conventional-changelog-cli": "^2.1.0",
"convert-svg-to-png": "^0.5.0",
"electron": "^10.0.1",
"electron-builder": "^22.8.0",
"electron-builder": "^22.8.1",
"electron-devtools-installer": "^3.1.1",
"electron-notarize": "^1.0.0",
"eslint": "^7.7.0",
"eslint-plugin-import": "^2.22.0",
"eslint-plugin-react": "^7.20.6",
"eslint-plugin-react": "^7.21.1",
"eslint-plugin-react-hooks": "^4.1.0",
"jest": "^26.4.2",
"npm-run-all": "^4.1.5",
"rollup": "^2.26.6",
"rollup": "^2.28.1",
"rollup-plugin-copy": "^3.3.0",
"ts-jest": "^26.3.0",
"typescript": "^4.0.2",
"ts-jest": "^26.4.0",
"typescript": "^4.0.3",
"xvfb-maybe": "^0.2.1"
},
"engines": {
Expand Down
Loading