Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Server in subdirectory #1820

Merged
merged 5 commits into from
Oct 16, 2020
Merged

fix: Server in subdirectory #1820

merged 5 commits into from
Oct 16, 2020

Conversation

tassoevan
Copy link
Collaborator

@tassoevan tassoevan commented Oct 15, 2020

Closes #1796

@tassoevan tassoevan added this to the 3.0.4 milestone Oct 15, 2020
@tassoevan tassoevan requested a review from a team October 15, 2020 21:39
@tassoevan tassoevan marked this pull request as ready for review October 15, 2020 22:32
@tassoevan
Copy link
Collaborator Author

@ura14h Would you mind taking a look at it?

@tassoevan tassoevan merged commit ff8b8a2 into master Oct 16, 2020
@tassoevan tassoevan deleted the fix/subdir branch October 16, 2020 17:06
@ura14h
Copy link
Contributor

ura14h commented Oct 17, 2020

@tassoevan Sure.

I pulled latest master and made sure 'yarn test' and 'yarn start'. And I inspected all URL with using developer tool console and network monitor. And I read code you changed.

Yes, I think that the app is working fine on my environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User can no longuer acces to server in a sub-folder hosting.
2 participants