[WIP-GSoC-19] Store Livechat sessions on backend side #242

knrt10 · 2019-06-08T11:49:56Z

package.json

src/components/App/index.js

reetp · 2019-06-14T11:25:06Z

Yes - this must not be automatically implemented, must have an off switch set to disabled by default, and be separately switchable from other information

eg you may wish to collect an email address but NOT geo location data

There must be some way to notify users of the data collection if it is enabled.

src/components/App/index.js

src/widget.js

geekgonecrazy · 2019-07-23T21:28:04Z

src/lib/location.js

+ * @returns {Object}
+ */
+const locationPrimary = async(latitude, longitude) => {
+	const { address } = await fetch(`https://nominatim.openstreetmap.org/reverse?format=json&lat=${ latitude }&lon=${ longitude }`, {


So this is going out to this api to grab location? This has to definitely be optional if done at all. Some serious privacy concerns around sending data like this out.

geekgonecrazy · 2019-07-23T21:28:23Z

src/lib/location.js

+ * @returns {Object}
+ */
+const locationBackup = async() => {
+	const location = await fetch('https://api.ipdata.co?api-key=test', {


reetp · 2019-08-02T09:55:48Z

Apart from truck loads of GDPR concerns here this, wording has a typo.

"please_enable_your_location_to_start_chat_this_is__c68e0f77": "Please enable your location to start chat. This is for your convinience only. Thanks",

"Please enable your location to start chat. This is for your convenience only. Thanks"

It also sounds like you are telling users that unless they enable location they cannot chat with you?

I don't think so.

You have to ask for permission before you take any data. You can't do it in the background and then say "oh please let me use this"
If you want to insist on obtaining location data before chatting then it needs an off switch for those that do not want to impose this
You have to be able to remove their data on request if you are storing it

Signed-off-by: knrt10 <[email protected]>

renatobecker-zz · 2019-08-25T20:42:43Z

src/api.js

-	|| queryString.parse(window.location.search).serverUrl
-	|| (process.env.NODE_ENV === 'development' ? 'http://localhost:3000' : null);
+// eslint-disable-next-line import/no-absolute-path
+import LivechatClient from '/Users/knrt10/dev/openSource/RocketChat/Rocket.Chat.js.SDK/dist/lib/clients/Livechat';


I think you forget to remove this code before pushing your changes.

renatobecker-zz · 2019-08-25T20:55:05Z

src/lib/location.js

@@ -0,0 +1,290 @@
+/* eslint-disable no-lonely-if */
+/* eslint-disable no-alert */
+import { getToken } from './main';


This is a clone from the userPresence lib, you don't need a new lib to do the same things, it does not make sense.
You can do what you want by calling the new methods related to session stuff within the userPresence lib.
Please, remove this file and move the new methods to a helper lib.

renatobecker-zz · 2019-08-25T21:00:08Z

src/routes/Chat/container.js

@@ -106,13 +106,15 @@ export class ChatContainer extends Component {
 			this.stopTypingDebounced.stop();
 			await Promise.all([
 				this.stopTyping({ rid, username: user.username }),
+				Livechat.updateSessionStatus('online', token),


Why call this method here?
We have a specific lib to deal with user status.

renatobecker-zz · 2019-08-25T21:02:20Z

src/routes/Register/container.js

@@ -30,6 +30,7 @@ export class RegisterContainer extends Component {
 		await dispatch({ loading: true, department });
 		try {
 			await Livechat.grantVisitor({ visitor: { ...fields, token } });
+			await Livechat.updateVisitorSessionOnRegister({ visitor: { ...fields, token } });


Why not just one method to update the livechat session?
You just need one method, you can pass specific data as parameters.

renatobecker-zz · 2019-08-25T21:03:23Z

src/components/App/index.js

@@ -149,6 +151,7 @@ export class App extends Component {
 	async finalize() {
 		CustomFields.reset();
 		userPresence.reset();
+		userSessionPresence.reset();


We don't need this lib.

renatobecker-zz · 2019-08-25T21:21:00Z

@knrt10
There is a lot of work to do here.

We just need one new method on the SDK, I suggest to call it as Livechat.updateVisitorSession.
Regardless of whether you submit the user's location or not, you can pass all information through the SDK method parameter, you don't need to create any other method;
You need to create a new setting on the backend side which will be used to allow/deny ask the user to collect its location on the widget side;

Please, keep in mind you need to reduce the complexity in this PR, one suggestion is to use just one method to handle the session data.
Feel free to ping me in case any of my comments are not clear for you.

Signed-off-by: knrt10 <[email protected]>

engelgabriel · 2019-09-19T02:15:12Z

RocketChat/feature-requests#135

tassoevan requested review from renatobecker-zz and tassoevan June 11, 2019 15:45

knrt10 mentioned this pull request Jun 12, 2019

[WIP-FEATURE-GSoC] Livechat: Real-Time Visitor Monitoring RocketChat/Rocket.Chat#14642

Closed

23 tasks

tassoevan suggested changes Jun 12, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

src/components/App/index.js Show resolved Hide resolved

knrt10 mentioned this pull request Jun 14, 2019

[NEW] Livechat API to get and set location of user to database. RocketChat/Rocket.Chat#14765

Open

knrt10 force-pushed the iplocation branch 2 times, most recently from 41cf4dd to 1608fba Compare June 16, 2019 14:38

renatobecker-zz changed the title ~~setting location Data for user~~ [WIP-GSoC-19] setting location Data for user Jun 17, 2019

renatobecker-zz suggested changes Jun 17, 2019

View reviewed changes

knrt10 force-pushed the iplocation branch from 645b15b to 5a4b355 Compare June 23, 2019 09:16

knrt10 force-pushed the iplocation branch from 5a4b355 to 8ed8a03 Compare July 8, 2019 04:35

reetp mentioned this pull request Jul 19, 2019

GDPR compliance, or lack of RocketChat/feature-requests#135

Open

knrt10 force-pushed the iplocation branch from 103dfae to b1ad6b9 Compare July 22, 2019 10:19

geekgonecrazy reviewed Jul 23, 2019

View reviewed changes

knrt10 force-pushed the iplocation branch from b1ad6b9 to d37febc Compare July 29, 2019 06:58

knrt10 added 12 commits August 14, 2019 11:33

added method to get location of user

7c0c54e

added new methods to save data to collection

55c34b9

asking for user permission for location

65593b2

Code fix

28675f9

Added new feature

8f37e07

Some working Fix

a95236b

Added contextual bar

c91b895

Active state changed to chatting

00078ab

Rebased code

58c8423

fixed status changing

dc1b2cc

Signed-off-by: knrt10 <[email protected]>

User status fix

7918686

Signed-off-by: knrt10 <[email protected]>

Added new field to location

bbdbd24

knrt10 force-pushed the iplocation branch from 5c1173e to b84e045 Compare August 14, 2019 15:49

Rebased code and fixed API

f8bb330

knrt10 force-pushed the iplocation branch from b84e045 to f8bb330 Compare August 14, 2019 15:50

knrt10 added 2 commits August 18, 2019 08:48

Code linted

34cd17e

Fixed session without location

bf85c25

renatobecker-zz changed the title ~~[WIP-GSoC-19] setting location Data for user~~ [WIP-GSoC-19] Store Livechat sessions on backend side Aug 25, 2019

renatobecker-zz suggested changes Aug 25, 2019

View reviewed changes

knrt10 added 2 commits August 26, 2019 18:25

Fixed code as per review

5281673

Fixed code as per review

816e75f

Signed-off-by: knrt10 <[email protected]>

tassoevan changed the base branch from dev to develop October 11, 2019 15:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP-GSoC-19] Store Livechat sessions on backend side #242

[WIP-GSoC-19] Store Livechat sessions on backend side #242

knrt10 commented Jun 8, 2019

reetp commented Jun 14, 2019

geekgonecrazy Jul 23, 2019

geekgonecrazy Jul 23, 2019

reetp commented Aug 2, 2019

renatobecker-zz Aug 25, 2019

renatobecker-zz Aug 25, 2019

renatobecker-zz Aug 25, 2019

renatobecker-zz Aug 25, 2019

renatobecker-zz Aug 25, 2019

renatobecker-zz commented Aug 25, 2019 •

edited

Loading

engelgabriel commented Sep 19, 2019

[WIP-GSoC-19] Store Livechat sessions on backend side #242

Are you sure you want to change the base?

[WIP-GSoC-19] Store Livechat sessions on backend side #242

Conversation

knrt10 commented Jun 8, 2019

reetp commented Jun 14, 2019

geekgonecrazy Jul 23, 2019

Choose a reason for hiding this comment

geekgonecrazy Jul 23, 2019

Choose a reason for hiding this comment

reetp commented Aug 2, 2019

renatobecker-zz Aug 25, 2019

Choose a reason for hiding this comment

renatobecker-zz Aug 25, 2019

Choose a reason for hiding this comment

renatobecker-zz Aug 25, 2019

Choose a reason for hiding this comment

renatobecker-zz Aug 25, 2019

Choose a reason for hiding this comment

renatobecker-zz Aug 25, 2019

Choose a reason for hiding this comment

renatobecker-zz commented Aug 25, 2019 • edited Loading

engelgabriel commented Sep 19, 2019

renatobecker-zz commented Aug 25, 2019 •

edited

Loading