review

RocketChat · Sep 1, 2022 · b36bd23 · b36bd23
1 parent fde96a4
commit b36bd23
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/packages/livechat/package.json b/packages/livechat/package.json
@@ -112,8 +112,5 @@
 		"updateFiles": [
 			"package.json"
 		]
-	},
-	"volta": {
-		"extends": "../../package.json"
 	}
 }
diff --git a/packages/livechat/src/widget.js b/packages/livechat/src/widget.js
@@ -70,6 +70,8 @@ function callHook(action, params) {
 }
 
 const updateWidgetStyle = (isOpened) => {
+	const isFullscreen = smallScreen && widget.dataset.state !== 'triggered';
+
 	if (smallScreen && isOpened) {
 		scrollPosition = document.documentElement.scrollTop;
 		document.body.classList.add('rc-livechat-mobile-full-screen');
@@ -80,8 +82,9 @@ const updateWidgetStyle = (isOpened) => {
 		}
 	}
 
+
 	if (isOpened) {
-		widget.style.left = smallScreen && widget.dataset.state !== 'triggered' ? '0' : 'auto';
+		widget.style.left = isFullscreen ? '0' : 'auto';
 
 		/**
 		 * If we use widget.style.height = smallScreen ? '100vh' : ...
@@ -91,8 +94,8 @@ const updateWidgetStyle = (isOpened) => {
 		 * for widget.style.width
 		 */
 
-		widget.style.height = smallScreen && widget.dataset.state !== 'triggered' ? '100%' : `${ WIDGET_MARGIN + widget_height + WIDGET_MARGIN + WIDGET_MINIMIZED_HEIGHT }px`;
-		widget.style.width = smallScreen && widget.dataset.state !== 'triggered' ? '100%' : `${ WIDGET_MARGIN + WIDGET_OPEN_WIDTH + WIDGET_MARGIN }px`;
+		widget.style.height = isFullscreen ? '100%' : `${ WIDGET_MARGIN + widget_height + WIDGET_MARGIN + WIDGET_MINIMIZED_HEIGHT }px`;
+		widget.style.width = isFullscreen ? '100%' : `${ WIDGET_MARGIN + WIDGET_OPEN_WIDTH + WIDGET_MARGIN }px`;
 	} else {
 		widget.style.left = 'auto';
 		widget.style.width = `${ WIDGET_MARGIN + WIDGET_MINIMIZED_WIDTH + WIDGET_MARGIN }px`;
@@ -159,17 +162,17 @@ const openWidget = () => {
 
 const resizeWidget = (height) => {
 	widget_height = height;
-	updateWidgetStyle(true);
 	widget.dataset.state = 'triggered';
+	updateWidgetStyle(true);
 };
 
 function closeWidget() {
 	if (widget.dataset.state === 'closed') {
 		return;
 	}
 
-	updateWidgetStyle(false);
 	widget.dataset.state = 'closed';
+	updateWidgetStyle(false);
 	emitCallback('chat-minimized');
 }
 

diff --git a/packages/livechat/webpack.config.js b/packages/livechat/webpack.config.js
@@ -177,7 +177,6 @@ module.exports = (env, argv) => [
 			clientLogLevel: 'trace',
 			overlay: true,
 			stats: 'normal',
-			writeToDisk: true,
 			watchOptions: {
 				ignored: [path.resolve(__dirname, './dist'), path.resolve(__dirname, './node_modules')],
 			},