Skip to content

Commit

Permalink
chore!: Deprecate apps downloadOnly param
Browse files Browse the repository at this point in the history
  • Loading branch information
MartinSchoeler authored and tassoevan committed Sep 27, 2024
1 parent f5f68c2 commit e6154df
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
6 changes: 0 additions & 6 deletions apps/meteor/ee/server/apps/communication/rest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -328,12 +328,6 @@ export class AppsRestApi {
orchestrator.getRocketChatLogger().error('Error getting the app from url:', e.response.data);
return API.v1.internalError();
}

if (this.bodyParams.downloadOnly) {
apiDeprecationLogger.parameter(this.request.route, 'downloadOnly', '7.0.0', this.response);

return API.v1.success({ buff });
}
} else if ('appId' in this.bodyParams && this.bodyParams.appId && this.bodyParams.marketplace && this.bodyParams.version) {
const baseUrl = orchestrator.getMarketplaceUrl();

Expand Down
3 changes: 1 addition & 2 deletions packages/rest-typings/src/apps/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -248,9 +248,8 @@ export type AppsEndpoints = {
version: string;
permissionsGranted?: IPermission[];
url?: string;
downloadOnly?: boolean;
}
| { url: string; downloadOnly?: boolean },
| { url: string },
):
| {
app: App;
Expand Down

0 comments on commit e6154df

Please sign in to comment.