Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading larg-sized Images #10980

Closed
reza899 opened this issue Jun 2, 2018 · 14 comments
Closed

Loading larg-sized Images #10980

reza899 opened this issue Jun 2, 2018 · 14 comments

Comments

@reza899
Copy link

reza899 commented Jun 2, 2018

Description:

Our Rocket not work correctly after upgrading to 65.1 in loading image,
the problem most see in large-sized images,
this problem happens on old posts (before upgrading to 65.1)

Server Setup Information:

  • Version of Rocket.Chat Server: 0.65.1
  • Operating System: Ubuntu 16.04 (4.4.0-87-generic)
  • Deployment Method(snap/docker/tar/etc): snap
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • Node Version: v8.11.1
  • mongoDB Version:
@geekgonecrazy
Copy link
Contributor

Not enough information to properly describe the issue. Please update to include more information

@TGriwenka
Copy link

I see the same issue, but with every large image that was uploaded or is uploaded.

I upload a large image and it is shown as you see in the two attached screenshots. It is shown the same in browser and in Rocket.Chat Client for MacOS (I tried already the actual developer version, which I compiled by myself).

First screenshot shows the image in the timeline. You see only part of the big image.

Second screenshot shows the image after I clicked on it in the timeline. There you see the complete original image...

screenshot_306

screenshot_305

@vynmera
Copy link
Contributor

vynmera commented Jun 4, 2018

Yeah, it seems the new lazyload doesn't scale images. So images that are too large just expand beyond the view.

@reetp
Copy link

reetp commented Jun 4, 2018

Same on docker 065.1

Really slows the loading and unnecessarily take up acres of screen real estate.

A real retrograde step.

@kuluev
Copy link

kuluev commented Jun 4, 2018

@rocket-cat label add "type: bug"

@rocket-cat
Copy link

rocket-cat bot commented Jun 4, 2018

You don't have permission to execute this command label

@kuluev
Copy link

kuluev commented Jun 4, 2018

I can confirm this. It happens when you upload a full-sized photo from android client.

@richardt3
Copy link

Timeline image previews are not being resized to an appropriate size but are being shown at the original file height and width. No scrollbars so image is useless. Either a css class has been deleted or a resize function is no longer being called.

@vynmera
Copy link
Contributor

vynmera commented Jun 4, 2018

@richardt3 I'm pretty sure a CSS class was lost, as the images no longer have cursor: pointer either. I'll look into it...

@richardt3
Copy link

@vynmera because of users shouting, I added a dirty hack piece of custom css to my install to make width 80% of the frame. Image is still a full download but doesn't take up the whole screen now.

@geekgonecrazy
Copy link
Contributor

Thanks for the fix @vynmera 👍

@ghost
Copy link

ghost commented Jun 11, 2018

@vynmera - nice one. I don't suppose you have the CSS handy? Save waiting for the next release :)

@vynmera
Copy link
Contributor

vynmera commented Jun 11, 2018

@acolville My fix includes a small HTML change too, so perhaps try out #10980 (comment) ?

@thepowerprocess
Copy link

quick fix before release

Administration > Layout > Custom CSS
add

.attachment-image img {
  max-width: 100%;
  max-height: 70vh;
  height: auto;
  width: auto;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants