Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unread Tray Icon Alert cannot be set to on #16288

Closed
xgdgsc opened this issue Jan 20, 2020 · 8 comments · Fixed by #16313
Closed

Unread Tray Icon Alert cannot be set to on #16288

xgdgsc opened this issue Jan 20, 2020 · 8 comments · Fixed by #16313
Assignees
@gabriellsh

Comments

@xgdgsc
Copy link
Contributor

xgdgsc commented Jan 20, 2020 •
edited
Loading

Description:

Whenever I set Unread Tray Icon Alert to on in my profile settings (in linux client or webpage), it will reload the page and it would turn to off. The default preference in admin settings is on.

Steps to reproduce:

  1. go to my profile settings,
  2. set Unread Tray Icon Alert to on

Expected behavior:

It keeps on and ever.

Actual behavior:

The page reloads and it is turned off.

Server Setup Information:

  • Version of Rocket.Chat Server: 2.4.1
  • Operating System: Linux centos 3.10.0-957.el7.x86_64
  • Deployment Method: docker compose
  • Number of Running Instances: 1
  • DB Replicaset Oplog: enabled
  • NodeJS Version: v8.17.0
  • MongoDB Version: 4.0.10

Client Setup Information

  • Desktop App or Browser Version: linux desktop 2.17.2
  • Operating System: Ubuntu 16.04

Relevant logs:

didn' t see any relevant
@ghost ghost mentioned this issue Jan 23, 2020
Merged
@ankar84 ankar84 mentioned this issue Jan 28, 2020
Closed
@ebyrne242 ebyrne242 mentioned this issue Feb 6, 2020
Closed
2 tasks
@ebyrne242
Copy link

It would be nice if we could get this fix into 3.0.0...

@novoid
Copy link

novoid commented Feb 7, 2020

Same here: Xubuntu 1910 (xfce 4.14), Rocket.Chat version 2.17.2-1555.

Although I never see the Rocket.Chat panel icon. the app "Rocket.Chat" is enabled in the list of applications in the notifications panel plugin. In the Rocket.Chat settings, notifications are enabled.

Whatever happens in Rocket.Chat, the icon does not get shown in the panel.

When I re-visit the Rocket.Chat preferences (My Account - Preferences - Messages), the setting for "Unread Tray Icon Alert" is set to "off" again.

@ankar84
Copy link

ankar84 commented Feb 11, 2020

I found another moment with that bug.
User can successfully change Unread Tray Icon Alert option by changing Require Interaction to Dismiss Desktop Notification option.
Unread Tray Icon Alert

@novoid
Copy link

novoid commented Feb 11, 2020

User can successfully change Unread Tray Icon Alert option by changing Require Interaction to Dismiss Desktop Notification option.

I can confirm that the "Unread Tray Icon Alert" settings stays active in this case. I don't receive any unread notification in my panel (except the working libnotify popup notification).

@xgdgsc xgdgsc mentioned this issue Mar 9, 2020
Closed
@Donal-Goggin
Copy link

Both of the fields have the same ID... Someone made a whoopsie :)

sameID

@Donal-Goggin
Copy link

If you just change the name of the unreadAlert ID in the notifications section before you submit the form it will set your preferences correctly.
It looks like the fix for this is already done it just hasn't been released.

@xgdgsc
Copy link
Contributor Author

xgdgsc commented Mar 31, 2020

It is not merged yet. Don' t know why 1 line takes so long.

ggazzo pushed a commit that referenced this issue Apr 14, 2020
[FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#…
ae903c2 
…16313)
gabriellsh added a commit that referenced this issue Apr 14, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into adm/…
ad7b0a5 
…users_and_rooms

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288)
  [FIX] User search on directory not working correctly (#17299)
  [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313)
  [FIX] Variable rendering problem on Import recent history page (#15997)
  [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215)
  [FIX] Discussions created from inside DMs were not working (#17282)
  [FIX] translation for nl (#16742)
  [FIX] No maxlength defined for custom user status (#16534)
  [FIX] Directory users email sort button (#16606)
  [FIX] In Create a New Channel, input should be focused on channel name instead of invite users (#16405)
  [FIX] Email not verified message (#16236)
  [FIX] Directory default tab (#17283)
  Update ru.i18n.json (#16869)
  [FIX] Avatar on sidebar when showing real names (#17286)
  Update Apps-Engine to stable version (#17287)
  [NEW][ENTERPRISE] Auto close abandoned Omnichannel rooms (#17055)
  Static props for Administration route components (#17285)
  [NEW] Default favorite channels (#16025)
  Apply $and helper to message template (#17280)
gabriellsh added a commit that referenced this issue Apr 15, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into adm/…
8739a89 
…mailer

* 'develop' of github.com:RocketChat/Rocket.Chat: (93 commits)
  [FIX] Red color error outline is not removed after password update (#16536)
  [FIX] Change wording to start DM from info panel (#8799)
  New hooks for RouterContext (#17305)
  [FIX] SAML assertion signature enforcement (#17278)
  [FIX] LDAP users lose session on refresh (#17302)
  [NEW] Add MMS support to Voxtelesys (#17217)
  [FIX] Popover component doesn't have scroll (#17198)
  [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288)
  [FIX] User search on directory not working correctly (#17299)
  [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313)
  [FIX] Variable rendering problem on Import recent history page (#15997)
  [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215)
  [FIX] Discussions created from inside DMs were not working (#17282)
  [FIX] translation for nl (#16742)
  [FIX] No maxlength defined for custom user status (#16534)
  [FIX] Directory users email sort button (#16606)
  [FIX] In Create a New Channel, input should be focused on channel name instead of invite users (#16405)
  [FIX] Email not verified message (#16236)
  [FIX] Directory default tab (#17283)
  Update ru.i18n.json (#16869)
  ...
ggazzo added a commit that referenced this issue Apr 15, 2020
@ggazzo
Merge branch 'adm/mailer' of github.com:RocketChat/Rocket.Chat into a…
8ba9fb0 
…dm/mailer

* 'adm/mailer' of github.com:RocketChat/Rocket.Chat: (79 commits)
  removed unecessary prop
  Fixed sendMail function
  Removed Log, Success message
  Permissions
  added route component
  [FIX] "Invalid Invite" message when registration is disabled (#17226)
  Added route, error handling.
  [FIX] Red color error outline is not removed after password update (#16536)
  [FIX] Change wording to start DM from info panel (#8799)
  New hooks for RouterContext (#17305)
  [FIX] SAML assertion signature enforcement (#17278)
  [FIX] LDAP users lose session on refresh (#17302)
  [NEW] Add MMS support to Voxtelesys (#17217)
  [FIX] Popover component doesn't have scroll (#17198)
  [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288)
  [FIX] User search on directory not working correctly (#17299)
  [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313)
  [FIX] Variable rendering problem on Import recent history page (#15997)
  [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215)
  [FIX] Discussions created from inside DMs were not working (#17282)
  ...
dudizilla added a commit that referenced this issue Apr 21, 2020
@dudizilla
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat i…
960d7dd 
…nto view-logs

* 'develop' of https://github.com/RocketChat/Rocket.Chat: (31 commits)
  Fixed componentes width (#17322)
  [IMPROVE] Administration -> Mailer Rewrite to React. (#17191)
  Regression: Storybook  added flowrouter group mock (#17321)
  [NEW] Feature/custom oauth mail field and interpolation for mapped fields (#15690)
  [FIX] "Invalid Invite" message when registration is disabled (#17226)
  [FIX] Red color error outline is not removed after password update (#16536)
  [FIX] Change wording to start DM from info panel (#8799)
  New hooks for RouterContext (#17305)
  [FIX] SAML assertion signature enforcement (#17278)
  [FIX] LDAP users lose session on refresh (#17302)
  [NEW] Add MMS support to Voxtelesys (#17217)
  [FIX] Popover component doesn't have scroll (#17198)
  [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288)
  [FIX] User search on directory not working correctly (#17299)
  [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313)
  [FIX] Variable rendering problem on Import recent history page (#15997)
  [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215)
  [FIX] Discussions created from inside DMs were not working (#17282)
  [FIX] translation for nl (#16742)
  [FIX] No maxlength defined for custom user status (#16534)
  ...
@novoid
Copy link

novoid commented Jul 30, 2020

FYI:

Xubuntu 20.04 LTS with Rocket.Chat 2.17.7: The corresponding setting can now be enabled independent from the "Require Interaction to Dismiss Desktop Notification" setting.

However, I still got no notifications within the tray or the notification widget. The latter also does not show any "Rocket.Chat" source but this could be disguised behind some Java stuff I can not interpret myself.

The only notification I got for new messages is the changing Icon in the workspace window list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabriellsh gabriellsh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] Can not save Unread Tray Icon Alert user preference
7 participants
@novoid @xgdgsc @ankar84 @ebyrne242 @Donal-Goggin @gabriellsh @dudizilla