Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Add support for RTL #165

Closed
shahar3012 opened this issue Jun 7, 2015 · 6 comments
Closed

Feature Request: Add support for RTL #165

shahar3012 opened this issue Jun 7, 2015 · 6 comments
Labels
contrib: experts needed
Milestone
0.3.0

Comments

@shahar3012
Copy link
Contributor

Rocket.Chat should support RTL in order to display the following languages properly:
Hebrew and Arabic.
Please consider adding this support. It should not take a lot of time to finish it.
@sampaiodiego
Copy link
Member

Can you help us with that @shahar3012 ? We don't know exactly what to change.. It has to be all the interface? Logo, room list position or what? We need some help to do this =)

thanks

@Schniz
Copy link
Contributor

Schniz commented Jun 9, 2015

@shahar3012 will help you (I know this guy....) and so do I.
the basic thing that should be implemented is that every input/textarea/message holder/username should be

<some-tag dir="auto">my text</some-tag>

this should set the direction automatically based on the language. no extra work needed on the alignment and directions and stuff. new browsers yay.

@Schniz
Copy link
Contributor

Schniz commented Jun 9, 2015

but it makes me wonder about the whole layout, should it be RTLed too?
from what I understand, you guys are working on translating the product (I can't see it, maybe it will be under the new settings page when it will come?), maybe if the user is on Arabic/Hebrew the whole layout should be RTL?

(that, of course, doesn't hurt the dir="auto", it helps for writing english/hebrew/arabic in one sentence)

@shahar3012
Copy link
Contributor Author

I'm working on RTL support. Will create pull request when finished.

@Schniz
Copy link
Contributor

Schniz commented Jun 11, 2015

@shahar3012 If I were you I'd create the PR with [WIP] at the beginning of the title.
this could help all of us comment and discuss about the pull request 😄

@shahar3012 shahar3012 mentioned this issue Jun 11, 2015
Merged
@engelgabriel
Copy link
Member

Please let me know if all works for you now.

@rodrigok rodrigok modified the milestone: v0.3 Jun 25, 2015
Peym4n pushed a commit to redlink-gmbh/Rocket.Chat that referenced this issue Jan 17, 2018
@mrsimpson @ruKurz
Informal german language for our custom texts (RocketChat#165)
7f99355 
* German language informalized - Liebe Deutsche, wir kennen euch nun besser. Wir wollen ab jetzt “Du” zu einander sagen 😉

* German texts of custom enhancement informalized
Peym4n pushed a commit to redlink-gmbh/Rocket.Chat that referenced this issue Jan 17, 2018
@mrsimpson @ruKurz
Release 0.59.3 0.5.0 (RocketChat#166)
c4f7b88 
* Fixed Issues 87, 88

* Feature/mrsimpson#23 title first message to new request (RocketChat#149)

* Request title and first message while creating new request
* Make titles of inputs and placeholders more consistent
* Fix display issues:

- Dropdown overlapped by input field
- In English, the width of the creation dialog was not 100%, thus input fields within too narrow

* Minor corrections with respect to error handling:

- Refactor error display to an own template
- Show error if selected expertise on request creation is invalid (not chosen from the dropdown)
- Fix positioning of "at" on members selection if invalid

* Fixes RocketChat#151 - Misspelled label "jetzt chaten" (RocketChat#152)

* Corrections to creation dialog (RocketChat#154)

* Corrections to creation dialog

- Propagate first message properly (fixes RocketChat#153)
- Change "Name" to "Title"
- get rid of flashing error message on auto-complete-confirmation with tab

* Corrections to creation dialog

- more robust error handling
- prevent flashing of validation errors

* Fix improper clearing of request title

* Invalid Expertise field highlight

* RocketChat#156 Prefill request creation form (RocketChat#157)

* fixes RocketChat#156

- Pass topic as URL param (URL encoded) as `topic` or `expertise` (same effect)
- Title is focused if expertise is passed

* Allow pre-filling of title and question as well.

This way, fixes mrsimpson#20 : The consumer (e. g. the wiki page) can create a simple form an pass the content as parameter

* - Use the copied current() instead of the internal value
```
FlowRouter.current
ƒ () {                                                                               // 248
  // We can't trust outside, that's why we clone this                                                        …
```
- refactor query-selectors => reuse

* use FlowRouter API properly

* Setting based permissions - downport (RocketChat#158)

* Allow maintenance of per-setting permissions

(cherry picked from commit eed869a)

* Implicitly assign and revoke setting group permissions

(cherry picked from commit 28b769b)

* Improve Display of setting permissions

(cherry picked from commit 8523456)

* Add path to permission title

(cherry picked from commit c87a30d)

* Permission to access setting permissions

(cherry picked from commit 48b1076)

* Adapt wording

(cherry picked from commit daccad8)

* UI-adaptation: Allow users with permission 'manage-selected-permissions' to see and change the affected settings.
However, this is not reactive: Once the permissions for a particular setting are changed, the user needs to log  off and on again before it becomes effective in the UI.
This is most probably a consequence of the CachedCollection. This collection needed to be changed on permission-change.
In the backend however, the permissions become effective immediately.

(cherry picked from commit 00e4bb5)

* Don't adapt sorting on the client side

(cherry picked from commit 9b71b62)

* Fix: Apply changed setting permissions reactively

(cherry picked from commit 293ad73)

* Move setting-based permissions to own collection

(cherry picked from commit 8f59f1c)

* Unify collections for setting and other permissions again into one

(cherry picked from commit 8d923c2)

* Get rid of frontend exceptions on changing selected settings

(cherry picked from commit a7fdc87)

* - Sort permissions by group
- Do not try to create permissions for hidden settings in higher-level-callbacks
- Remove `setting-permissions` collection - fully integrated into `permissions`

(cherry picked from commit f007231)

* Harmonize wording in German

(cherry picked from commit 5cf5df2)

* German language informalized (RocketChat#160)

* German language informalized - Liebe Deutsche, wir kennen euch nun besser. Wir wollen ab jetzt “Du” zu einander sagen 😉

* Update de.i18n.json

* Update de.i18n.json

* Update de.i18n.json

* Allow administration even if user has got only `edit-privileged-setting` but not `view-privileged-setting`

* Revert "Fixed Issues 87, 88 (livechat on mobile devices)" (RocketChat#164)

* Create configuration expert role on startup (RocketChat#159)

* Allow maintenance of per-setting permissions

(cherry picked from commit eed869a)

* Implicitly assign and revoke setting group permissions

(cherry picked from commit 28b769b)

* Improve Display of setting permissions

(cherry picked from commit 8523456)

* Add path to permission title

(cherry picked from commit c87a30d)

* Permission to access setting permissions

(cherry picked from commit 48b1076)

* Adapt wording

(cherry picked from commit daccad8)

* UI-adaptation: Allow users with permission 'manage-selected-permissions' to see and change the affected settings.
However, this is not reactive: Once the permissions for a particular setting are changed, the user needs to log  off and on again before it becomes effective in the UI.
This is most probably a consequence of the CachedCollection. This collection needed to be changed on permission-change.
In the backend however, the permissions become effective immediately.

(cherry picked from commit 00e4bb5)

* Don't adapt sorting on the client side

(cherry picked from commit 9b71b62)

* Fix: Apply changed setting permissions reactively

(cherry picked from commit 293ad73)

* Move setting-based permissions to own collection

(cherry picked from commit 8f59f1c)

* Unify collections for setting and other permissions again into one

(cherry picked from commit 8d923c2)

* Get rid of frontend exceptions on changing selected settings

(cherry picked from commit a7fdc87)

* - Sort permissions by group
- Do not try to create permissions for hidden settings in higher-level-callbacks
- Remove `setting-permissions` collection - fully integrated into `permissions`

(cherry picked from commit f007231)

* Harmonize wording in German

(cherry picked from commit 5cf5df2)

* add configuration package

* Add default role configuration on startup

* set default system language to DE

* Reduce capabilities of config expert and introduce minor admin

* Parted the roles for configuration and managing the rest

- Manager - well - manages the application, like a minor admin. Target is that this role is capable of doing everything which is necessary while *regularly* running the application
- Config-expert is allowed to customize the application (affecting all users' experience)

* Informal german language for our custom texts (RocketChat#165)

* German language informalized - Liebe Deutsche, wir kennen euch nun besser. Wir wollen ab jetzt “Du” zu einander sagen 😉

* German texts of custom enhancement informalized

* Bump version to 0.5.0

* Update HISTORY.md
HappyTobi pushed a commit to HappyTobi/Rocket.Chat that referenced this issue Jul 10, 2018
@szwacz
Merge pull request RocketChat#165 from pcewing/master
77608b3 
Added a missing semicolon.
shubhsherl pushed a commit to shubhsherl/Rocket.Chat that referenced this issue Feb 24, 2020
@ear-dev
Merge pull request RocketChat#165 from WideChat/ear_sidebar_item_fix
1751caa 
fix hide room and other sidebar items
@sitedata sitedata mentioned this issue Mar 11, 2021
Open
@BMondly BMondly mentioned this issue Mar 11, 2021
Open
@wasimakh2 wasimakh2 mentioned this issue Mar 11, 2021
Open
@toshanmugaraj toshanmugaraj mentioned this issue Mar 11, 2021
Open
@saurabharch saurabharch mentioned this issue Mar 11, 2021
Open
@timtheguy timtheguy mentioned this issue Mar 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contrib: experts needed
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
5 participants
@rodrigok @engelgabriel @Schniz @shahar3012 @sampaiodiego