Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github login requires email to be public #200

Closed
est31 opened this issue Jun 17, 2015 · 4 comments
Closed

Github login requires email to be public #200

est31 opened this issue Jun 17, 2015 · 4 comments
Assignees
@marceloschmidt
Labels
feat: app settings
Milestone
0.8.0

Comments

@est31
Copy link

est31 commented Jun 17, 2015

The log in with github button requires that the e-mail is public. The application should rather ask for the e-mail through the github API, then users with non-public e-mails can log in, too.
@engelgabriel
Copy link
Member

👍

We will make the whole email "thing" optional.

@engelgabriel
Copy link
Member

Depends on #222

@engelgabriel engelgabriel added this to the v1.0 milestone Jun 30, 2015
@engelgabriel
Copy link
Member

Depends on #250

@rodrigok rodrigok modified the milestones: v1.0, Next Aug 15, 2015
@engelgabriel engelgabriel mentioned this issue Aug 19, 2015
Closed
@engelgabriel engelgabriel modified the milestones: v1.0, Next Aug 19, 2015
@marceloschmidt marceloschmidt mentioned this issue Aug 20, 2015
Merged
@marceloschmidt
Copy link
Member

Closed by PR #515

tkurz pushed a commit to redlink-gmbh/Rocket.Chat that referenced this issue Mar 13, 2018
@mrsimpson
Merge pull request RocketChat#200 from redlink-gmbh/new-smarti-widget
0b78dc5 
There still are some issues in the widget itself and one unnecessary log for the legacy service.
Apart from that, the widget backend looks fine, separate issues have been created => merging
HappyTobi pushed a commit to HappyTobi/Rocket.Chat that referenced this issue Jul 10, 2018
@surculus12
Close RocketChat#200; Added /silent switch to the .exe installer
4320ad6
HappyTobi pushed a commit to HappyTobi/Rocket.Chat that referenced this issue Jul 10, 2018
@rodrigok
Merge pull request RocketChat#208 from surculus12/develop
0258295 
Close RocketChat#200; Added /silent switch to the .exe installer
HappyTobi pushed a commit to HappyTobi/Rocket.Chat that referenced this issue Jul 10, 2018
@szwacz
Merge pull request RocketChat#200 from black-snow/patch-1
416b2cc 
added MIT LICENSE file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marceloschmidt marceloschmidt

Labels
feat: app settings
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
5 participants
@rodrigok @engelgabriel @marceloschmidt @sampaiodiego @est31