Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a class per Roletag #3019

Closed
lunitic opened this issue Apr 24, 2016 · 2 comments
Closed

Make a class per Roletag #3019

lunitic opened this issue Apr 24, 2016 · 2 comments

Comments

@lunitic
Copy link

lunitic commented Apr 24, 2016

Today its not possible to do custom css per role. There is only one tag.

I would suggest the following change in packages/rocketchat-ui-message/message/message.html

{{#each roleTags}}
<span class="role-tag-{{.}}">{{.}}</span>

Then every role will have a unique tag.

marceloschmidt added a commit that referenced this issue Apr 25, 2016
Add data-role attribute to role tags, allowing custom CSS
@marceloschmidt
Copy link
Member

Instead of class="role-tag-{{.}}" we opted for data-role="{{.}} which can also be accessed in CSS and we won't have problems with spaces in role description.

@lunitic
Copy link
Author

lunitic commented Apr 25, 2016

@marceloschmidt Works too 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants