Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possiblity breaking changes in new Meteor version #3134

Closed
mitar opened this issue May 4, 2016 · 6 comments
Closed

Possiblity breaking changes in new Meteor version #3134

mitar opened this issue May 4, 2016 · 6 comments

Comments

@mitar
Copy link
Contributor

mitar commented May 4, 2016

Meteor will probably have this batching feature merged in.

I think as a consequence, meteor streams will stop working.

Personally, I would claim that Rocket.Chat should move away for streams anyway for and just use control-mergebox package (#1710), but it would be probably good to first even see if it is really breaking anything.

@marceloschmidt
Copy link
Member

We started using our own streamer: https://github.com/RocketChat/meteor-streamer
It is possible that it will also break, but let's confirm it first.

@rodrigok
Copy link
Member

rodrigok commented May 4, 2016

@mitar I did some tests with the project around the package (as you can see here https://github.com/RocketChat/meteor-streamer) upgrading the project meteor update --release 1.3.3-ddp-batching-beta.0 and everything is working great.

So I will close this issue for now, if you find another problem please reopen it.

Thanks.

@rodrigok rodrigok closed this as completed May 4, 2016
@geekgonecrazy
Copy link
Contributor

Thanks for bringing this up! Always best to try before hand then be blindsided.

Personally, I would claim that Rocket.Chat should move away for streams anyway for and just use control-mergebox package (#1710)

@mitar personally i'm interested to hear some of your thoughts behind thinking we should move towards control-mergebox instead of streams.

@mitar
Copy link
Contributor Author

mitar commented May 4, 2016

Let's have that conversation in #1710.

@mitar
Copy link
Contributor Author

mitar commented May 4, 2016

Also see #894.

@geekgonecrazy
Copy link
Contributor

ah thanks! I have some reading to do 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants