-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some emojis (emoticons) break the MD parser #32577
Comments
does it happen with just post? I'm interested in looking into this and working on it |
What do you mean by "just post"? I've tried a banch of strategies and different grammars, but didn't susceed. I have a few tests but every time one of them fails :). Perhaps, it will help to someone.
|
Thanks for opening this bug. I suspect it is also related to this which is being looked at. Whether it is a Rocket bug or a more generic limitation or parser bug I don't know. |
…en using certain characters in bold, such as *text:*, the : caused a conflict, preventing the bold formatting from working correctly. I fixed the bug by modifying the message-parser (grammar.pegjs) and adding new rules.
Fix RocketChat#32577: Some emojis (emoticons) break the MD parser fix of whitespace Fix RocketChat#32577: Some emojis (emoticons) break the MD parser.
Hey there! |
Issues are not assigned. Please try what you want but be aware that someone else looks like they are working on it, and I believe the devs are on it in the background and it is likely fixed in 6.10 See the referenced bug above. |
Description:
If you post a message like this one:
*text:*
you will not get a bold text or text with emoji.I suppose, there is a bug in a PEG grammar: see packages/message-parser/src/grammar.pegjs
Some where between rules Bold and Emoticon. The root of this case is
:*
- kissing_heart emoticon.I've thired to figure out how this PEG works, but failed.
Steps to reproduce:
*text:*
Expected behavior:
There is a bolded text
text:
Actual behavior:
There is just a text.
Note: If you post
*text :*
you will get*text
and an emoji.Server Setup Information:
Client Setup Information
The text was updated successfully, but these errors were encountered: